41 lines
1.3 KiB
Diff
41 lines
1.3 KiB
Diff
From 5de9751997cf490088f62f41fd92be57cf7ceea4 Mon Sep 17 00:00:00 2001
|
|
From: Stanislav Brabec <sbrabec@suse.cz>
|
|
Date: Wed, 27 Feb 2019 23:22:19 +0100
|
|
Subject: [PATCH 666/686] agetty: Fix input of non-ASCII characters in
|
|
get_logname()
|
|
|
|
As login supports non-ASCII characters in the logname, agetty should be
|
|
consistent.
|
|
|
|
8b58ffdd re-activated old and ASCII-only get_logname(), which restricted
|
|
the input to ASCII only. As the code does not read whole characters,
|
|
isascii(ascval) and isprint(ascval) returns nonsenses after entering a
|
|
non-ASCII character.
|
|
|
|
As keyboard maps don't contain unprintable non-control characters, it
|
|
seems to be relatively safe to remove both checks.
|
|
|
|
Signed-off-by: Stanislav Brabec <sbrabec@suse.cz>
|
|
Cc: Lubomir Rintel <lkundrak@v3.sk>
|
|
Tested-by: Lubomir Rintel <lkundrak@v3.sk>
|
|
---
|
|
term-utils/agetty.c | 2 --
|
|
1 file changed, 2 deletions(-)
|
|
|
|
diff --git a/term-utils/agetty.c b/term-utils/agetty.c
|
|
index 1a3ebc3..0ef8ba3 100644
|
|
--- a/term-utils/agetty.c
|
|
+++ b/term-utils/agetty.c
|
|
@@ -2175,8 +2175,6 @@ static char *get_logname(struct issue *ie, struct options *op, struct termios *t
|
|
case CTL('D'):
|
|
exit(EXIT_SUCCESS);
|
|
default:
|
|
- if (!isascii(ascval) || !isprint(ascval))
|
|
- break;
|
|
if ((size_t)(bp - logname) >= sizeof(logname) - 1)
|
|
log_err(_("%s: input overrun"), op->tty);
|
|
if ((tp->c_lflag & ECHO) == 0)
|
|
--
|
|
1.8.3.1
|
|
|