40 lines
1.4 KiB
Diff
40 lines
1.4 KiB
Diff
From c5d548379b25705c2061b8c010f78fd242212f65 Mon Sep 17 00:00:00 2001
|
|
From: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
|
|
Date: Tue, 14 Sep 2021 16:12:14 +0300
|
|
Subject: [PATCH] trace-cmd library: Fix version string memory leak
|
|
|
|
The version string is allocated when a VERSION option is processed, but
|
|
is never freed. Free it on input handler close.
|
|
|
|
Link: https://lore.kernel.org/linux-trace-devel/20210914131232.3964615-4-tz.stoyanov@gmail.com
|
|
|
|
Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
|
|
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
|
|
---
|
|
lib/trace-cmd/trace-input.c | 2 ++
|
|
1 file changed, 2 insertions(+)
|
|
|
|
diff --git a/lib/trace-cmd/trace-input.c b/lib/trace-cmd/trace-input.c
|
|
index 0dbcdbdc..9253bc37 100644
|
|
--- a/lib/trace-cmd/trace-input.c
|
|
+++ b/lib/trace-cmd/trace-input.c
|
|
@@ -3518,6 +3518,7 @@ void tracecmd_close(struct tracecmd_input *handle)
|
|
free(handle->cpu_data);
|
|
free(handle->uname);
|
|
free(handle->trace_clock);
|
|
+ free(handle->version);
|
|
close(handle->fd);
|
|
|
|
tracecmd_free_hooks(handle->hooks);
|
|
@@ -3959,6 +3960,7 @@ tracecmd_buffer_instance_handle(struct tracecmd_input *handle, int indx)
|
|
new_handle->cpu_data = NULL;
|
|
new_handle->nr_buffers = 0;
|
|
new_handle->buffers = NULL;
|
|
+ new_handle->version = NULL;
|
|
new_handle->ref = 1;
|
|
if (handle->trace_clock) {
|
|
new_handle->trace_clock = strdup(handle->trace_clock);
|
|
--
|
|
2.33.0
|
|
|