77 lines
3.8 KiB
Diff
77 lines
3.8 KiB
Diff
From 47c1db6730b8a81b01e8505a648624fa6ad0bbd7 Mon Sep 17 00:00:00 2001
|
|
From: Benjamin Berg <bberg@redhat.com>
|
|
Date: Mon, 12 Oct 2020 11:02:26 +0200
|
|
Subject: [PATCH] xdg-autostart: Lower most info messages to debug level
|
|
|
|
It is expected for numerous autostart files to not be convertible to
|
|
corresponding units. The information is only useful for someone
|
|
debugging why a file might not be started, but it is not generally
|
|
useful for users in most situations.
|
|
|
|
As such, lower the warnings. Anyone wondering why an application is not
|
|
started will easily notice that the unit is not generated. From there it
|
|
will be somewhat harder to figure out why, but the overall trade-off is
|
|
still improved.
|
|
|
|
Fixes: #17305
|
|
---
|
|
src/xdg-autostart-generator/xdg-autostart-service.c | 12 ++++++------
|
|
1 file changed, 6 insertions(+), 6 deletions(-)
|
|
|
|
diff --git a/src/xdg-autostart-generator/xdg-autostart-service.c b/src/xdg-autostart-generator/xdg-autostart-service.c
|
|
index c6f39f2..6324c50 100644
|
|
--- a/src/xdg-autostart-generator/xdg-autostart-service.c
|
|
+++ b/src/xdg-autostart-generator/xdg-autostart-service.c
|
|
@@ -483,7 +483,7 @@ static int xdg_autostart_generate_desktop_condition(
|
|
|
|
r = find_binary(test_binary, &gnome_autostart_condition_path);
|
|
if (r < 0) {
|
|
- log_full_errno(r == -ENOENT ? LOG_INFO : LOG_WARNING, r,
|
|
+ log_full_errno(r == -ENOENT ? LOG_DEBUG : LOG_WARNING, r,
|
|
"%s not found: %m", test_binary);
|
|
fprintf(f, "# ExecCondition using %s skipped due to missing binary.\n", test_binary);
|
|
return r;
|
|
@@ -514,18 +514,18 @@ int xdg_autostart_service_generate_unit(
|
|
|
|
/* Nothing to do for hidden services. */
|
|
if (service->hidden) {
|
|
- log_info("Not generating service for XDG autostart %s, it is hidden.", service->name);
|
|
+ log_debug("Not generating service for XDG autostart %s, it is hidden.", service->name);
|
|
return 0;
|
|
}
|
|
|
|
if (service->systemd_skip) {
|
|
- log_info("Not generating service for XDG autostart %s, should be skipped by generator.", service->name);
|
|
+ log_debug("Not generating service for XDG autostart %s, should be skipped by generator.", service->name);
|
|
return 0;
|
|
}
|
|
|
|
/* Nothing to do if type is not Application. */
|
|
if (!streq_ptr(service->type, "Application")) {
|
|
- log_info("Not generating service for XDG autostart %s, only Type=Application is supported.", service->name);
|
|
+ log_debug("Not generating service for XDG autostart %s, only Type=Application is supported.", service->name);
|
|
return 0;
|
|
}
|
|
|
|
@@ -541,7 +541,7 @@ int xdg_autostart_service_generate_unit(
|
|
if (service->try_exec) {
|
|
r = find_binary(service->try_exec, NULL);
|
|
if (r < 0) {
|
|
- log_full_errno(r == -ENOENT ? LOG_INFO : LOG_WARNING, r,
|
|
+ log_full_errno(r == -ENOENT ? LOG_DEBUG : LOG_WARNING, r,
|
|
"Not generating service for XDG autostart %s, could not find TryExec= binary %s: %m",
|
|
service->name, service->try_exec);
|
|
return 0;
|
|
@@ -558,7 +558,7 @@ int xdg_autostart_service_generate_unit(
|
|
|
|
if (service->gnome_autostart_phase) {
|
|
/* There is no explicit value for the "Application" phase. */
|
|
- log_info("Not generating service for XDG autostart %s, startup phases are not supported.",
|
|
+ log_debug("Not generating service for XDG autostart %s, startup phases are not supported.",
|
|
service->name);
|
|
return 0;
|
|
}
|
|
--
|
|
2.23.0
|
|
|