351 lines
14 KiB
Diff
351 lines
14 KiB
Diff
From e0d61dac3324abc90f61014a98b1bc5a9a1f60ae Mon Sep 17 00:00:00 2001
|
|
From: Yu Watanabe <watanabe.yu+github@gmail.com>
|
|
Date: Wed, 16 Jun 2021 19:18:56 +0900
|
|
Subject: [PATCH] udev: also rename struct udev_ctrl -> UdevCtrl
|
|
|
|
Reference:https://github.com/systemd/systemd/commit/e0d61dac3324abc90f61014a98b1bc5a9a1f60ae
|
|
Conflict:NA
|
|
|
|
---
|
|
src/udev/udev-ctrl.c | 52 ++++++++++++++++++------------------
|
|
src/udev/udev-ctrl.h | 54 +++++++++++++++++++-------------------
|
|
src/udev/udevadm-control.c | 2 +-
|
|
src/udev/udevadm-settle.c | 2 +-
|
|
src/udev/udevadm-trigger.c | 2 +-
|
|
src/udev/udevd.c | 4 +--
|
|
6 files changed, 58 insertions(+), 58 deletions(-)
|
|
|
|
diff --git a/src/udev/udev-ctrl.c b/src/udev/udev-ctrl.c
|
|
index 3d563547190c..00279ba3d87d 100644
|
|
--- a/src/udev/udev-ctrl.c
|
|
+++ b/src/udev/udev-ctrl.c
|
|
@@ -23,14 +23,14 @@
|
|
/* wire protocol magic must match */
|
|
#define UDEV_CTRL_MAGIC 0xdead1dea
|
|
|
|
-struct udev_ctrl_msg_wire {
|
|
+typedef struct UdevCtrlMessageWire {
|
|
char version[16];
|
|
unsigned magic;
|
|
- enum udev_ctrl_msg_type type;
|
|
- union udev_ctrl_msg_value value;
|
|
-};
|
|
+ UdevCtrlMessageType type;
|
|
+ UdevCtrlMessageValue value;
|
|
+} UdevCtrlMessageWire;
|
|
|
|
-struct udev_ctrl {
|
|
+struct UdevCtrl {
|
|
unsigned n_ref;
|
|
int sock;
|
|
int sock_connect;
|
|
@@ -47,9 +47,9 @@ struct udev_ctrl {
|
|
void *userdata;
|
|
};
|
|
|
|
-int udev_ctrl_new_from_fd(struct udev_ctrl **ret, int fd) {
|
|
+int udev_ctrl_new_from_fd(UdevCtrl **ret, int fd) {
|
|
_cleanup_close_ int sock = -1;
|
|
- struct udev_ctrl *uctrl;
|
|
+ UdevCtrl *uctrl;
|
|
|
|
assert(ret);
|
|
|
|
@@ -59,11 +59,11 @@ int udev_ctrl_new_from_fd(struct udev_ctrl **ret, int fd) {
|
|
return log_error_errno(errno, "Failed to create socket: %m");
|
|
}
|
|
|
|
- uctrl = new(struct udev_ctrl, 1);
|
|
+ uctrl = new(UdevCtrl, 1);
|
|
if (!uctrl)
|
|
return -ENOMEM;
|
|
|
|
- *uctrl = (struct udev_ctrl) {
|
|
+ *uctrl = (UdevCtrl) {
|
|
.n_ref = 1,
|
|
.sock = fd >= 0 ? fd : TAKE_FD(sock),
|
|
.sock_connect = -1,
|
|
@@ -81,7 +81,7 @@ int udev_ctrl_new_from_fd(struct udev_ctrl **ret, int fd) {
|
|
return 0;
|
|
}
|
|
|
|
-int udev_ctrl_enable_receiving(struct udev_ctrl *uctrl) {
|
|
+int udev_ctrl_enable_receiving(UdevCtrl *uctrl) {
|
|
int r;
|
|
|
|
assert(uctrl);
|
|
@@ -107,7 +107,7 @@ int udev_ctrl_enable_receiving(struct udev_ctrl *uctrl) {
|
|
return 0;
|
|
}
|
|
|
|
-static void udev_ctrl_disconnect(struct udev_ctrl *uctrl) {
|
|
+static void udev_ctrl_disconnect(UdevCtrl *uctrl) {
|
|
if (!uctrl)
|
|
return;
|
|
|
|
@@ -115,7 +115,7 @@ static void udev_ctrl_disconnect(struct udev_ctrl *uctrl) {
|
|
uctrl->sock_connect = safe_close(uctrl->sock_connect);
|
|
}
|
|
|
|
-static struct udev_ctrl *udev_ctrl_free(struct udev_ctrl *uctrl) {
|
|
+static UdevCtrl *udev_ctrl_free(UdevCtrl *uctrl) {
|
|
assert(uctrl);
|
|
|
|
udev_ctrl_disconnect(uctrl);
|
|
@@ -127,9 +127,9 @@ static struct udev_ctrl *udev_ctrl_free(struct udev_ctrl *uctrl) {
|
|
return mfree(uctrl);
|
|
}
|
|
|
|
-DEFINE_TRIVIAL_REF_UNREF_FUNC(struct udev_ctrl, udev_ctrl, udev_ctrl_free);
|
|
+DEFINE_TRIVIAL_REF_UNREF_FUNC(UdevCtrl, udev_ctrl, udev_ctrl_free);
|
|
|
|
-int udev_ctrl_cleanup(struct udev_ctrl *uctrl) {
|
|
+int udev_ctrl_cleanup(UdevCtrl *uctrl) {
|
|
if (!uctrl)
|
|
return 0;
|
|
if (uctrl->cleanup_socket)
|
|
@@ -137,7 +137,7 @@ int udev_ctrl_cleanup(struct udev_ctrl *uctrl) {
|
|
return 0;
|
|
}
|
|
|
|
-int udev_ctrl_attach_event(struct udev_ctrl *uctrl, sd_event *event) {
|
|
+int udev_ctrl_attach_event(UdevCtrl *uctrl, sd_event *event) {
|
|
int r;
|
|
|
|
assert_return(uctrl, -EINVAL);
|
|
@@ -154,25 +154,25 @@ int udev_ctrl_attach_event(struct udev_ctrl *uctrl, sd_event *event) {
|
|
return 0;
|
|
}
|
|
|
|
-sd_event_source *udev_ctrl_get_event_source(struct udev_ctrl *uctrl) {
|
|
+sd_event_source *udev_ctrl_get_event_source(UdevCtrl *uctrl) {
|
|
assert(uctrl);
|
|
|
|
return uctrl->event_source;
|
|
}
|
|
|
|
-static void udev_ctrl_disconnect_and_listen_again(struct udev_ctrl *uctrl) {
|
|
+static void udev_ctrl_disconnect_and_listen_again(UdevCtrl *uctrl) {
|
|
udev_ctrl_disconnect(uctrl);
|
|
udev_ctrl_unref(uctrl);
|
|
(void) sd_event_source_set_enabled(uctrl->event_source, SD_EVENT_ON);
|
|
/* We don't return NULL here because uctrl is not freed */
|
|
}
|
|
|
|
-DEFINE_TRIVIAL_CLEANUP_FUNC_FULL(struct udev_ctrl*, udev_ctrl_disconnect_and_listen_again, NULL);
|
|
+DEFINE_TRIVIAL_CLEANUP_FUNC_FULL(UdevCtrl*, udev_ctrl_disconnect_and_listen_again, NULL);
|
|
|
|
static int udev_ctrl_connection_event_handler(sd_event_source *s, int fd, uint32_t revents, void *userdata) {
|
|
- _cleanup_(udev_ctrl_disconnect_and_listen_againp) struct udev_ctrl *uctrl = NULL;
|
|
- struct udev_ctrl_msg_wire msg_wire;
|
|
- struct iovec iov = IOVEC_MAKE(&msg_wire, sizeof(struct udev_ctrl_msg_wire));
|
|
+ _cleanup_(udev_ctrl_disconnect_and_listen_againp) UdevCtrl *uctrl = NULL;
|
|
+ UdevCtrlMessageWire msg_wire;
|
|
+ struct iovec iov = IOVEC_MAKE(&msg_wire, sizeof(UdevCtrlMessageWire));
|
|
CMSG_BUFFER_TYPE(CMSG_SPACE(sizeof(struct ucred))) control;
|
|
struct msghdr smsg = {
|
|
.msg_iov = &iov,
|
|
@@ -235,7 +235,7 @@ static int udev_ctrl_connection_event_handler(sd_event_source *s, int fd, uint32
|
|
}
|
|
|
|
static int udev_ctrl_event_handler(sd_event_source *s, int fd, uint32_t revents, void *userdata) {
|
|
- struct udev_ctrl *uctrl = userdata;
|
|
+ UdevCtrl *uctrl = userdata;
|
|
_cleanup_close_ int sock = -1;
|
|
struct ucred ucred;
|
|
int r;
|
|
@@ -282,7 +282,7 @@ static int udev_ctrl_event_handler(sd_event_source *s, int fd, uint32_t revents,
|
|
return 0;
|
|
}
|
|
|
|
-int udev_ctrl_start(struct udev_ctrl *uctrl, udev_ctrl_handler_t callback, void *userdata) {
|
|
+int udev_ctrl_start(UdevCtrl *uctrl, udev_ctrl_handler_t callback, void *userdata) {
|
|
int r;
|
|
|
|
assert(uctrl);
|
|
@@ -309,8 +309,8 @@ int udev_ctrl_start(struct udev_ctrl *uctrl, udev_ctrl_handler_t callback, void
|
|
return 0;
|
|
}
|
|
|
|
-int udev_ctrl_send(struct udev_ctrl *uctrl, enum udev_ctrl_msg_type type, int intval, const char *buf) {
|
|
- struct udev_ctrl_msg_wire ctrl_msg_wire = {
|
|
+int udev_ctrl_send(UdevCtrl *uctrl, UdevCtrlMessageType type, int intval, const char *buf) {
|
|
+ UdevCtrlMessageWire ctrl_msg_wire = {
|
|
.version = "udev-" STRINGIFY(PROJECT_VERSION),
|
|
.magic = UDEV_CTRL_MAGIC,
|
|
.type = type,
|
|
@@ -339,7 +339,7 @@ int udev_ctrl_send(struct udev_ctrl *uctrl, enum udev_ctrl_msg_type type, int in
|
|
return 0;
|
|
}
|
|
|
|
-int udev_ctrl_wait(struct udev_ctrl *uctrl, usec_t timeout) {
|
|
+int udev_ctrl_wait(UdevCtrl *uctrl, usec_t timeout) {
|
|
_cleanup_(sd_event_source_unrefp) sd_event_source *source_io = NULL, *source_timeout = NULL;
|
|
int r;
|
|
|
|
diff --git a/src/udev/udev-ctrl.h b/src/udev/udev-ctrl.h
|
|
index 680fbf7bff1d..ca80c2aa4e0d 100644
|
|
--- a/src/udev/udev-ctrl.h
|
|
+++ b/src/udev/udev-ctrl.h
|
|
@@ -6,9 +6,9 @@
|
|
#include "macro.h"
|
|
#include "time-util.h"
|
|
|
|
-struct udev_ctrl;
|
|
+typedef struct UdevCtrl UdevCtrl;
|
|
|
|
-enum udev_ctrl_msg_type {
|
|
+typedef enum UdevCtrlMessageType {
|
|
_UDEV_CTRL_END_MESSAGES,
|
|
UDEV_CTRL_SET_LOG_LEVEL,
|
|
UDEV_CTRL_STOP_EXEC_QUEUE,
|
|
@@ -18,62 +18,62 @@ enum udev_ctrl_msg_type {
|
|
UDEV_CTRL_SET_CHILDREN_MAX,
|
|
UDEV_CTRL_PING,
|
|
UDEV_CTRL_EXIT,
|
|
-};
|
|
+} UdevCtrlMessageType;
|
|
|
|
-union udev_ctrl_msg_value {
|
|
+typedef union UdevCtrlMessageValue {
|
|
int intval;
|
|
char buf[256];
|
|
-};
|
|
+} UdevCtrlMessageValue;
|
|
|
|
-typedef int (*udev_ctrl_handler_t)(struct udev_ctrl *udev_ctrl, enum udev_ctrl_msg_type type,
|
|
- const union udev_ctrl_msg_value *value, void *userdata);
|
|
+typedef int (*udev_ctrl_handler_t)(UdevCtrl *udev_ctrl, UdevCtrlMessageType type,
|
|
+ const UdevCtrlMessageValue *value, void *userdata);
|
|
|
|
-int udev_ctrl_new_from_fd(struct udev_ctrl **ret, int fd);
|
|
-static inline int udev_ctrl_new(struct udev_ctrl **ret) {
|
|
+int udev_ctrl_new_from_fd(UdevCtrl **ret, int fd);
|
|
+static inline int udev_ctrl_new(UdevCtrl **ret) {
|
|
return udev_ctrl_new_from_fd(ret, -1);
|
|
}
|
|
|
|
-int udev_ctrl_enable_receiving(struct udev_ctrl *uctrl);
|
|
-struct udev_ctrl *udev_ctrl_ref(struct udev_ctrl *uctrl);
|
|
-struct udev_ctrl *udev_ctrl_unref(struct udev_ctrl *uctrl);
|
|
-int udev_ctrl_cleanup(struct udev_ctrl *uctrl);
|
|
-int udev_ctrl_attach_event(struct udev_ctrl *uctrl, sd_event *event);
|
|
-int udev_ctrl_start(struct udev_ctrl *uctrl, udev_ctrl_handler_t callback, void *userdata);
|
|
-sd_event_source *udev_ctrl_get_event_source(struct udev_ctrl *uctrl);
|
|
+int udev_ctrl_enable_receiving(UdevCtrl *uctrl);
|
|
+UdevCtrl *udev_ctrl_ref(UdevCtrl *uctrl);
|
|
+UdevCtrl *udev_ctrl_unref(UdevCtrl *uctrl);
|
|
+int udev_ctrl_cleanup(UdevCtrl *uctrl);
|
|
+int udev_ctrl_attach_event(UdevCtrl *uctrl, sd_event *event);
|
|
+int udev_ctrl_start(UdevCtrl *uctrl, udev_ctrl_handler_t callback, void *userdata);
|
|
+sd_event_source *udev_ctrl_get_event_source(UdevCtrl *uctrl);
|
|
|
|
-int udev_ctrl_wait(struct udev_ctrl *uctrl, usec_t timeout);
|
|
+int udev_ctrl_wait(UdevCtrl *uctrl, usec_t timeout);
|
|
|
|
-int udev_ctrl_send(struct udev_ctrl *uctrl, enum udev_ctrl_msg_type type, int intval, const char *buf);
|
|
-static inline int udev_ctrl_send_set_log_level(struct udev_ctrl *uctrl, int priority) {
|
|
+int udev_ctrl_send(UdevCtrl *uctrl, UdevCtrlMessageType type, int intval, const char *buf);
|
|
+static inline int udev_ctrl_send_set_log_level(UdevCtrl *uctrl, int priority) {
|
|
return udev_ctrl_send(uctrl, UDEV_CTRL_SET_LOG_LEVEL, priority, NULL);
|
|
}
|
|
|
|
-static inline int udev_ctrl_send_stop_exec_queue(struct udev_ctrl *uctrl) {
|
|
+static inline int udev_ctrl_send_stop_exec_queue(UdevCtrl *uctrl) {
|
|
return udev_ctrl_send(uctrl, UDEV_CTRL_STOP_EXEC_QUEUE, 0, NULL);
|
|
}
|
|
|
|
-static inline int udev_ctrl_send_start_exec_queue(struct udev_ctrl *uctrl) {
|
|
+static inline int udev_ctrl_send_start_exec_queue(UdevCtrl *uctrl) {
|
|
return udev_ctrl_send(uctrl, UDEV_CTRL_START_EXEC_QUEUE, 0, NULL);
|
|
}
|
|
|
|
-static inline int udev_ctrl_send_reload(struct udev_ctrl *uctrl) {
|
|
+static inline int udev_ctrl_send_reload(UdevCtrl *uctrl) {
|
|
return udev_ctrl_send(uctrl, UDEV_CTRL_RELOAD, 0, NULL);
|
|
}
|
|
|
|
-static inline int udev_ctrl_send_set_env(struct udev_ctrl *uctrl, const char *key) {
|
|
+static inline int udev_ctrl_send_set_env(UdevCtrl *uctrl, const char *key) {
|
|
return udev_ctrl_send(uctrl, UDEV_CTRL_SET_ENV, 0, key);
|
|
}
|
|
|
|
-static inline int udev_ctrl_send_set_children_max(struct udev_ctrl *uctrl, int count) {
|
|
+static inline int udev_ctrl_send_set_children_max(UdevCtrl *uctrl, int count) {
|
|
return udev_ctrl_send(uctrl, UDEV_CTRL_SET_CHILDREN_MAX, count, NULL);
|
|
}
|
|
|
|
-static inline int udev_ctrl_send_ping(struct udev_ctrl *uctrl) {
|
|
+static inline int udev_ctrl_send_ping(UdevCtrl *uctrl) {
|
|
return udev_ctrl_send(uctrl, UDEV_CTRL_PING, 0, NULL);
|
|
}
|
|
|
|
-static inline int udev_ctrl_send_exit(struct udev_ctrl *uctrl) {
|
|
+static inline int udev_ctrl_send_exit(UdevCtrl *uctrl) {
|
|
return udev_ctrl_send(uctrl, UDEV_CTRL_EXIT, 0, NULL);
|
|
}
|
|
|
|
-DEFINE_TRIVIAL_CLEANUP_FUNC(struct udev_ctrl*, udev_ctrl_unref);
|
|
+DEFINE_TRIVIAL_CLEANUP_FUNC(UdevCtrl*, udev_ctrl_unref);
|
|
diff --git a/src/udev/udevadm-control.c b/src/udev/udevadm-control.c
|
|
index 20820dd64723..06c61e5c07c6 100644
|
|
--- a/src/udev/udevadm-control.c
|
|
+++ b/src/udev/udevadm-control.c
|
|
@@ -48,7 +48,7 @@ static int help(void) {
|
|
}
|
|
|
|
int control_main(int argc, char *argv[], void *userdata) {
|
|
- _cleanup_(udev_ctrl_unrefp) struct udev_ctrl *uctrl = NULL;
|
|
+ _cleanup_(udev_ctrl_unrefp) UdevCtrl *uctrl = NULL;
|
|
usec_t timeout = 60 * USEC_PER_SEC;
|
|
int c, r;
|
|
|
|
diff --git a/src/udev/udevadm-settle.c b/src/udev/udevadm-settle.c
|
|
index 84b4f9ca4588..6da9439bd28a 100644
|
|
--- a/src/udev/udevadm-settle.c
|
|
+++ b/src/udev/udevadm-settle.c
|
|
@@ -176,7 +176,7 @@ int settle_main(int argc, char *argv[], void *userdata) {
|
|
|
|
/* guarantee that the udev daemon isn't pre-processing */
|
|
if (getuid() == 0) {
|
|
- _cleanup_(udev_ctrl_unrefp) struct udev_ctrl *uctrl = NULL;
|
|
+ _cleanup_(udev_ctrl_unrefp) UdevCtrl *uctrl = NULL;
|
|
|
|
if (udev_ctrl_new(&uctrl) >= 0) {
|
|
r = udev_ctrl_send_ping(uctrl);
|
|
diff --git a/src/udev/udevadm-trigger.c b/src/udev/udevadm-trigger.c
|
|
index 8acf3d9b1189..a24073fb7341 100644
|
|
--- a/src/udev/udevadm-trigger.c
|
|
+++ b/src/udev/udevadm-trigger.c
|
|
@@ -421,7 +421,7 @@ int trigger_main(int argc, char *argv[], void *userdata) {
|
|
}
|
|
|
|
if (ping) {
|
|
- _cleanup_(udev_ctrl_unrefp) struct udev_ctrl *uctrl = NULL;
|
|
+ _cleanup_(udev_ctrl_unrefp) UdevCtrl *uctrl = NULL;
|
|
|
|
r = udev_ctrl_new(&uctrl);
|
|
if (r < 0)
|
|
diff --git a/src/udev/udevd.c b/src/udev/udevd.c
|
|
index 6baedd2f2e69..a35b095dd141 100644
|
|
--- a/src/udev/udevd.c
|
|
+++ b/src/udev/udevd.c
|
|
@@ -94,7 +94,7 @@ typedef struct Manager {
|
|
sd_netlink *rtnl;
|
|
|
|
sd_device_monitor *monitor;
|
|
- struct udev_ctrl *ctrl;
|
|
+ UdevCtrl *ctrl;
|
|
int worker_watch[2];
|
|
|
|
/* used by udev-watch */
|
|
@@ -1067,7 +1067,7 @@ static int on_uevent(sd_device_monitor *monitor, sd_device *dev, void *userdata)
|
|
}
|
|
|
|
/* receive the udevd message from userspace */
|
|
-static int on_ctrl_msg(struct udev_ctrl *uctrl, enum udev_ctrl_msg_type type, const union udev_ctrl_msg_value *value, void *userdata) {
|
|
+static int on_ctrl_msg(UdevCtrl *uctrl, UdevCtrlMessageType type, const UdevCtrlMessageValue *value, void *userdata) {
|
|
Manager *manager = userdata;
|
|
int r;
|
|
|