36 lines
1.2 KiB
Diff
36 lines
1.2 KiB
Diff
From 5f6dbf2ab29bcd30c701cab3daecf5a6a53a44cd Mon Sep 17 00:00:00 2001
|
|
From: Joseph Sutton <josephsutton@catalyst.net.nz>
|
|
Date: Wed, 12 Oct 2022 13:57:55 +1300
|
|
Subject: [PATCH 09/15] CVE-2022-3437 source4/heimdal: Use constant-time
|
|
memcmp() in unwrap_des3()
|
|
|
|
The surrounding checks all use ct_memcmp(), so this one was presumably
|
|
meant to as well.
|
|
|
|
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15134
|
|
|
|
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
|
|
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
|
|
|
|
Conflict: NA
|
|
Reference: https://download.samba.org/pub/samba/patches/security/samba-4.15.11-security-2022-10-25.patch
|
|
---
|
|
source4/heimdal/lib/gssapi/krb5/unwrap.c | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
diff --git a/source4/heimdal/lib/gssapi/krb5/unwrap.c b/source4/heimdal/lib/gssapi/krb5/unwrap.c
|
|
index b3da35ee9e2..7111a7944fe 100644
|
|
--- a/source4/heimdal/lib/gssapi/krb5/unwrap.c
|
|
+++ b/source4/heimdal/lib/gssapi/krb5/unwrap.c
|
|
@@ -227,7 +227,7 @@ unwrap_des3
|
|
if (ret)
|
|
return ret;
|
|
|
|
- if (memcmp (p, "\x04\x00", 2) != 0) /* HMAC SHA1 DES3_KD */
|
|
+ if (ct_memcmp (p, "\x04\x00", 2) != 0) /* HMAC SHA1 DES3_KD */
|
|
return GSS_S_BAD_SIG;
|
|
p += 2;
|
|
if (ct_memcmp (p, "\x02\x00", 2) == 0) {
|
|
--
|
|
2.25.1
|