ba7a351bb3
The issues mainly lies in the memory empty check, variable range inconsistency, parameter verification, and print format. Signed-off-by: Luoyouming <luoyouming@huawei.com> Signed-off-by: Chengchang Tang <tangchengchang@huawei.com Signed-off-by: Ran Zhou <zhouran10@h-partners.com> (cherry picked from commit 918525387673e173835fd287995470cbaccad784)
37 lines
1.2 KiB
Diff
37 lines
1.2 KiB
Diff
From c989f93b01c45f8453bc839722f91ddc8b000037 Mon Sep 17 00:00:00 2001
|
|
From: Chengchang Tang <tangchengchang@huawei.com>
|
|
Date: Mon, 27 Nov 2023 16:39:52 +0800
|
|
Subject: [PATCH 75/75] libhns: Fix unnecessary dca memory detach
|
|
|
|
driver inclusion
|
|
category: bugfix
|
|
bugzilla: https://gitee.com/src-openeuler/rdma-core/issues/I8J2Y5?from=project-issue
|
|
|
|
--------------------------------------------------------------------------
|
|
|
|
If sq is not enabled, it should not detach dca mem. Moreover, under the
|
|
current code logic, if detach dca mem, its sq index will be a random
|
|
value because it is not initialized.
|
|
|
|
Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
|
|
---
|
|
providers/hns/hns_roce_u_hw_v2.c | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
diff --git a/providers/hns/hns_roce_u_hw_v2.c b/providers/hns/hns_roce_u_hw_v2.c
|
|
index fc938de..2fb738d 100644
|
|
--- a/providers/hns/hns_roce_u_hw_v2.c
|
|
+++ b/providers/hns/hns_roce_u_hw_v2.c
|
|
@@ -696,7 +696,7 @@ static void dca_detach_qp_buf(struct hns_roce_context *ctx,
|
|
hns_roce_spin_unlock(&qp->rq.hr_lock);
|
|
hns_roce_spin_unlock(&qp->sq.hr_lock);
|
|
|
|
- if (is_empty)
|
|
+ if (is_empty && qp->sq.wqe_cnt > 0)
|
|
hns_roce_detach_dca_mem(ctx, qp->verbs_qp.qp.handle, &attr);
|
|
}
|
|
|
|
--
|
|
2.25.1
|
|
|