dabf4d530e
1.Fix the owner bit error of sq in new io 2.Fix incorrect post-send with direct wqe of 3.Add a judgment to the congestion control algorithm Singed-off-by: Juan Zhou <zhoujuan51@h-partners.com> (cherry picked from commit 092143ba858a7aba0630fadd416faa2a4e7eaf06)
50 lines
1.8 KiB
Diff
50 lines
1.8 KiB
Diff
From cfea6efe6decfa8c209ad9a85e1290674370725e Mon Sep 17 00:00:00 2001
|
|
From: Junxian Huang <huangjunxian6@hisilicon.com>
|
|
Date: Fri, 2 Jun 2023 10:33:15 +0800
|
|
Subject: [PATCH 3/4] libhns: Fix incorrect post-send with direct wqe of
|
|
wr-list in user space
|
|
|
|
driver inclusion
|
|
category: bugfix
|
|
bugzilla: https://gitee.com/openeuler/kernel/issues/I7A2SA
|
|
|
|
---------------------------------------------------------------
|
|
|
|
Currently, direct wqe is not supported for wr-list. RoCE driver excludes
|
|
direct wqe for wr-list by judging whether the number of wr is 1.
|
|
|
|
For a wr-list where the second wr is a length-error atomic wr, the
|
|
post-send driver handles the first wr and adds 1 to the wr number counter
|
|
firstly. While handling the second wr, the driver finds out a length error
|
|
and terminates the wr handle process, remaining the counter at 1. This
|
|
causes the driver mistakenly judges there is only 1 wr and thus enters
|
|
the direct wqe process, carrying the current length-error atomic wqe.
|
|
|
|
This patch fixes the error by adding a judgement whether the current wr
|
|
is a bad wr. If so, use the normal doorbell process but not direct wqe
|
|
despite the wr number is 1.
|
|
|
|
Fixes: 159933c37450 ("libhns: Add support for direct wqe")
|
|
Signed-off-by: Junxian Huang <huangjunxian6@hisilicon.com>
|
|
---
|
|
providers/hns/hns_roce_u_hw_v2.c | 3 ++-
|
|
1 file changed, 2 insertions(+), 1 deletion(-)
|
|
|
|
diff --git a/providers/hns/hns_roce_u_hw_v2.c b/providers/hns/hns_roce_u_hw_v2.c
|
|
index cde4801..bb26c59 100644
|
|
--- a/providers/hns/hns_roce_u_hw_v2.c
|
|
+++ b/providers/hns/hns_roce_u_hw_v2.c
|
|
@@ -1480,7 +1480,8 @@ out:
|
|
|
|
udma_to_device_barrier();
|
|
|
|
- if (nreq == 1 && (qp->flags & HNS_ROCE_QP_CAP_DIRECT_WQE))
|
|
+ if (nreq == 1 && !ret &&
|
|
+ (qp->flags & HNS_ROCE_QP_CAP_DIRECT_WQE))
|
|
hns_roce_write_dwqe(qp, wqe);
|
|
else
|
|
hns_roce_update_sq_db(ctx, qp);
|
|
--
|
|
2.25.1
|
|
|