From d1409106e1323c54fbbb0618c071efb024f58130 Mon Sep 17 00:00:00 2001 From: Junxian Huang Date: Thu, 13 Mar 2025 17:26:52 +0800 Subject: [PATCH 55/55] libhns: Fix wrong order of spin unlock in modify qp mainline inclusion from mainline-v56.0-65 commit d2b41c86c49335b3c6ab638abb1c0e31f5ba0e8f category: bugfix bugzilla: https://gitee.com/src-openeuler/rdma-core/issues/IC1V44 CVE: NA Reference: https://github.com/linux-rdma/rdma-core/pull/1579/commits/d2b41c86c49335b3c6... --------------------------------------------------------------------- The spin_unlock order should be the reverse of spin_lock order. Fixes: 179f015e090d ("libhns: Add support for lock-free QP") Signed-off-by: Junxian Huang Signed-off-by: Xinghai Cen --- providers/hns/hns_roce_u_hw_v2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/providers/hns/hns_roce_u_hw_v2.c b/providers/hns/hns_roce_u_hw_v2.c index cea3043..3a1249f 100644 --- a/providers/hns/hns_roce_u_hw_v2.c +++ b/providers/hns/hns_roce_u_hw_v2.c @@ -1910,8 +1910,8 @@ static int hns_roce_u_v2_modify_qp(struct ibv_qp *qp, struct ibv_qp_attr *attr, if (flag) { if (!ret) qp->state = IBV_QPS_ERR; - hns_roce_spin_unlock(&hr_qp->sq.hr_lock); hns_roce_spin_unlock(&hr_qp->rq.hr_lock); + hns_roce_spin_unlock(&hr_qp->sq.hr_lock); } if (ret) -- 2.33.0