- coro: support live patch for libcare
- tests/acpi: Update expected ACPI tables for vcpu hotplug(update BinDir)
- arm/virt: Require mc->has_hotpluggable_cpus for cold-plugged vcpu
- arm/virt: Consider has_ged when set mc->has_hotpluggable_cpus
- arm/virt-acpi: Require possible_cpu_arch_ids for build_cpus_aml()
- acpi/ged: Remove cpuhp field of ged
- acpi/ged: Init cpu hotplug only when machine support it
- intc/gicv3: Fixes for vcpu hotplug
- arm/kvm: Set psci smccc filter only with vcpu hotplug
- accel/kvm: Use correct id for parked vcpu
- arm/virt: Fix adjudgement of core_id for vcpu hotplugged
- arm/virt.c: Convey local_err when set psci-conduit
- system/cpus: Fix resume_all_vcpus() under vCPU hotplug condition
- system/cpus: Fix pause_all_vcpus() under concurrent environment
- acpi/cpu: Fix cpu_hotplug_hw_init()
- arm/cpu: Some fixes for arm_cpu_unrealizefn()
- system/physmem: Fix possible double free when destroy cpu as
- hw/arm/virt: Expose cold-booted CPUs as MADT GICC Enabled
- tcg/mttcg: enable threads to unregister in tcg_ctxs[]
- hw/arm: Support hotplug capability check using _OSC method
- target/arm/kvm,tcg: Register/Handle SMCCC hypercall exits to VMM/Qemu
- target/arm/kvm: Write CPU state back to KVM on reset
- target/arm: Add support of *unrealize* ARMCPU during vCPU Hot-unplug
- physmem,gdbstub: Common helping funcs/changes to *unrealize* vCPU
- hw/arm: Changes required for reset and to support next boot
- arm/virt: Update the guest(via GED) about CPU hot-(un)plug events
- hw/intc/arm-gicv3*: Changes required to (re)init the vCPU register info
- hw/arm,gicv3: Changes to update GIC with vCPU hot-plug notification
- arm/virt: Changes to (un)wire GICC<->vCPU IRQs during hot-(un)plug
- arm/virt: Add/update basic hot-(un)plug framework
- hw/acpi: Update ACPI GED framework to support vCPU Hotplug
- arm/virt: Release objects for *disabled* possible vCPUs after init
- hw/acpi: Make _MAT method optional
- hw/arm: MADT Tbl change to size the guest with possible vCPUs
- hw/acpi: Update GED _EVT method AML with cpu scan
- hw/acpi: ACPI/AML Changes to reflect the correct _STA.{PRES,ENA} Bits to Guest
- arm/virt: Make ARM vCPU *present* status ACPI *persistent*
- arm/virt/acpi: Build CPUs AML with CPU Hotplug support
- tests/acpi/bios-tables-test: Allow changes to virt/DSDT file
- acpi/cpu: Add cpu_cppc building support
- arm/virt/acpi: Factor out CPPC building from DSDT CPU aml
- hw/acpi: Update CPUs AML with cpu-(ctrl)dev change
- arm/virt: Create GED dev before *disabled* CPU Objs are destroyed
- arm/virt: Add cpu hotplug events to GED during creation
- hw/acpi: Init GED framework with cpu hotplug events
- hw/acpi: Use qemu_present_cpu() API in ACPI CPU hotplug init
- hw/acpi: Add ACPI CPU hotplug init stub
- arm/acpi: Enable ACPI support for vcpu hotplug
- hw/acpi: Move CPU ctrl-dev MMIO region len macro to common header file
- arm/virt: Init PMU at host for all possible vcpus
- arm/virt,gicv3: Changes to pre-size GIC with possible vcpus @machine init
- arm/virt,kvm: Pre-create disabled possible vCPUs @machine init
- accel/kvm: Extract common KVM vCPU {creation,parking} code
- arm/virt,target/arm: Machine init time change common to vCPU {cold|hot}-plug
- hw/arm/virt: Move setting of common CPU properties in a function
- cpus-common: Add common CPU utility for possible vCPUs
- arm/virt,target/arm: Add new ARMCPU {socket,cluster,core,thread}-id property
Signed-off-by: Jiabo Feng <fengjiabo1@huawei.com>
124 lines
4.4 KiB
Diff
124 lines
4.4 KiB
Diff
From afb71c88d935349cdf9763e8f51f77334ab615ec Mon Sep 17 00:00:00 2001
|
|
From: Salil Mehta <salil.mehta@huawei.com>
|
|
Date: Fri, 8 May 2020 18:54:10 +0100
|
|
Subject: [PATCH] arm/virt: Update the guest(via GED) about CPU hot-(un)plug
|
|
events
|
|
|
|
During any vCPU hot-(un)plug, running guest VM needs to be intimated about the
|
|
new vCPU being added or request the deletion of the vCPU which is already part
|
|
of the guest VM. This is done using the ACPI GED event which eventually gets
|
|
demultiplexed to a CPU hotplug event and further to specific hot-(un)plug event
|
|
of a particular vCPU.
|
|
|
|
This change adds the ACPI calls to the existing hot-(un)plug hooks to trigger
|
|
ACPI GED events from QEMU to guest VM.
|
|
|
|
Co-developed-by: Salil Mehta <salil.mehta@huawei.com>
|
|
Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
|
|
Co-developed-by: Keqian Zhu <zhukeqian1@huawei.com>
|
|
Signed-off-by: Keqian Zhu <zhukeqian1@huawei.com>
|
|
Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
|
|
---
|
|
hw/arm/virt.c | 33 ++++++++++++++++++++++++++++++---
|
|
1 file changed, 30 insertions(+), 3 deletions(-)
|
|
|
|
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
|
|
index 0312fa366d..60cd560ab9 100644
|
|
--- a/hw/arm/virt.c
|
|
+++ b/hw/arm/virt.c
|
|
@@ -3256,6 +3256,7 @@ static void virt_cpu_plug(HotplugHandler *hotplug_dev, DeviceState *dev,
|
|
VirtMachineState *vms = VIRT_MACHINE(hotplug_dev);
|
|
MachineState *ms = MACHINE(hotplug_dev);
|
|
CPUState *cs = CPU(dev);
|
|
+ Error *local_err = NULL;
|
|
CPUArchId *cpu_slot;
|
|
|
|
/* insert the cold/hot-plugged vcpu in the slot */
|
|
@@ -3268,12 +3269,20 @@ static void virt_cpu_plug(HotplugHandler *hotplug_dev, DeviceState *dev,
|
|
* plugged, guest is also notified.
|
|
*/
|
|
if (vms->acpi_dev) {
|
|
- /* TODO: update acpi hotplug state. Send cpu hotplug event to guest */
|
|
+ HotplugHandlerClass *hhc;
|
|
+ /* update acpi hotplug state and send cpu hotplug event to guest */
|
|
+ hhc = HOTPLUG_HANDLER_GET_CLASS(vms->acpi_dev);
|
|
+ hhc->plug(HOTPLUG_HANDLER(vms->acpi_dev), dev, &local_err);
|
|
+ if (local_err) {
|
|
+ goto fail;
|
|
+ }
|
|
/* TODO: register cpu for reset & update F/W info for the next boot */
|
|
}
|
|
|
|
cs->disabled = false;
|
|
return;
|
|
+fail:
|
|
+ error_propagate(errp, local_err);
|
|
}
|
|
|
|
static void virt_cpu_unplug_request(HotplugHandler *hotplug_dev,
|
|
@@ -3281,8 +3290,10 @@ static void virt_cpu_unplug_request(HotplugHandler *hotplug_dev,
|
|
{
|
|
MachineClass *mc = MACHINE_GET_CLASS(qdev_get_machine());
|
|
VirtMachineState *vms = VIRT_MACHINE(hotplug_dev);
|
|
+ HotplugHandlerClass *hhc;
|
|
ARMCPU *cpu = ARM_CPU(dev);
|
|
CPUState *cs = CPU(dev);
|
|
+ Error *local_err = NULL;
|
|
|
|
if (!vms->acpi_dev || !dev->realized) {
|
|
error_setg(errp, "GED does not exists or device is not realized!");
|
|
@@ -3301,9 +3312,16 @@ static void virt_cpu_unplug_request(HotplugHandler *hotplug_dev,
|
|
return;
|
|
}
|
|
|
|
- /* TODO: request cpu hotplug from guest */
|
|
+ /* request cpu hotplug from guest */
|
|
+ hhc = HOTPLUG_HANDLER_GET_CLASS(vms->acpi_dev);
|
|
+ hhc->unplug_request(HOTPLUG_HANDLER(vms->acpi_dev), dev, &local_err);
|
|
+ if (local_err) {
|
|
+ goto fail;
|
|
+ }
|
|
|
|
return;
|
|
+fail:
|
|
+ error_propagate(errp, local_err);
|
|
}
|
|
|
|
static void virt_cpu_unplug(HotplugHandler *hotplug_dev, DeviceState *dev,
|
|
@@ -3311,7 +3329,9 @@ static void virt_cpu_unplug(HotplugHandler *hotplug_dev, DeviceState *dev,
|
|
{
|
|
VirtMachineState *vms = VIRT_MACHINE(hotplug_dev);
|
|
MachineState *ms = MACHINE(hotplug_dev);
|
|
+ HotplugHandlerClass *hhc;
|
|
CPUState *cs = CPU(dev);
|
|
+ Error *local_err = NULL;
|
|
CPUArchId *cpu_slot;
|
|
|
|
if (!vms->acpi_dev || !dev->realized) {
|
|
@@ -3321,7 +3341,12 @@ static void virt_cpu_unplug(HotplugHandler *hotplug_dev, DeviceState *dev,
|
|
|
|
cpu_slot = virt_find_cpu_slot(ms, cs->cpu_index);
|
|
|
|
- /* TODO: update the acpi cpu hotplug state for cpu hot-unplug */
|
|
+ /* update the acpi cpu hotplug state for cpu hot-unplug */
|
|
+ hhc = HOTPLUG_HANDLER_GET_CLASS(vms->acpi_dev);
|
|
+ hhc->unplug(HOTPLUG_HANDLER(vms->acpi_dev), dev, &local_err);
|
|
+ if (local_err) {
|
|
+ goto fail;
|
|
+ }
|
|
|
|
unwire_gic_cpu_irqs(vms, cs);
|
|
virt_update_gic(vms, cs);
|
|
@@ -3335,6 +3360,8 @@ static void virt_cpu_unplug(HotplugHandler *hotplug_dev, DeviceState *dev,
|
|
cs->disabled = true;
|
|
|
|
return;
|
|
+fail:
|
|
+ error_propagate(errp, local_err);
|
|
}
|
|
|
|
static void virt_machine_device_pre_plug_cb(HotplugHandler *hotplug_dev,
|
|
--
|
|
2.27.0
|
|
|