1f0277483b
- block: bugfix: Don't pause vm when NOSPACE EIO happened - block: enable cache mode of empty cdrom - block/mirror: fix file-system went to read-only after block-mirror - scsi-bus: fix incorrect call for blk_error_retry_reset_timeout() - scsi-bus: fix unmatched object_unref() - block: Add sanity check when setting retry parameters - block-backend: Stop retrying when draining - scsi-disk: Add support for retry on errors - scsi-bus: Refactor the code that retries requests - virtio_blk: Add support for retry on errors - block: Add error retry param setting - block-backend: Add timeout support for retry - block-backend: Enable retry action on errors - block-backend: Add device specific retry callback - block-backend: Introduce retry timer - qapi/block-core: Add retry option for error action - scsi: bugfix: fix division by zero - scsi: cdrom: Fix crash after remote cdrom detached - qemu-pr: fixed ioctl failed for multipath disk - scsi-disk: define props in scsi_block_disk to avoid memleaks - bugfix: fix possible memory leak - bugfix: fix some illegal memory access and memory leak - util/log: add CONFIG_DISABLE_QEMU_LOG macro - log: Add some logs on VM runtime path - bugfix: fix eventfds may double free when vm_id reused in ivshmem - hw/display/macfb: Fix missing ERRP_GUARD() in macfb_nubus_realize() - hw/cxl/cxl-host: Fix missing ERRP_GUARD() in cxl_fixed_memory_window_config() - qemu-img create: 'cache' paramter only use for reg file image - qemu-img: add qemu-img direct create - qemu-img block: set zero flags only when discard_zeros of the block supported - Revert "file-posix: Remove unused s->discard_zeroes" - pcie_sriov: Validate NumVFs (CVE-2024-26327) - hw/nvme: Use pcie_sriov_num_vfs() (CVE-2024-26328) - hw/acpi/cpu: Use CPUState typedef - target/i386/sev: Fix missing ERRP_GUARD() for error_prepend() - virtio-gpu: remove needless condition - hw/i2c/smbus_slave: Add object path on error prints - vfio/pci: Ascend710 change to bar2 quirk - vfio/pci: Ascend910 need 4Bytes quirk in bar0 - vfio/pci: Ascend710 need 4Bytes quirk in bar0 - vfio/pci: Ascend310 need 4Bytes quirk in bar4 - chardev/char-socket: Fix TLS io channels sending too much data to the backend - i386/cpuid: Move leaf 7 to correct group - i386/cpuid: Decrease cpuid_i when skipping CPUID leaf 1F - i386/cpu: Mask with XCR0/XSS mask for FEAT_XSAVE_XCR0_HI and FEAT_XSAVE_XSS_HI leafs - i386/cpu: Clear FEAT_XSAVE_XSS_LO/HI leafs when CPUID_EXT_XSAVE is not available - blkio: Respect memory-alignment for bounce buffer allocations - virtio-gpu: Correct virgl_renderer_resource_get_info() error check - hw/usb: Style cleanup - tests/qemu-iotests: resolved the problem that the 108 test cases in the container fail Signed-off-by: Jiabo Feng <fengjiabo1@huawei.com> (cherry picked from commit 404d45bf9147058a475a8031c454a6c8e0acc123)
44 lines
1.3 KiB
Diff
44 lines
1.3 KiB
Diff
From c2f55f210d4e021121865ea31037d2751188befd Mon Sep 17 00:00:00 2001
|
|
From: Yan Wang <wangyan122@huawei.com>
|
|
Date: Tue, 1 Mar 2022 20:12:12 +0800
|
|
Subject: [PATCH] scsi-bus: fix unmatched object_unref()
|
|
|
|
Fix commit 391dd8f1("scsi-bus: Refactor the code that retries requests"),
|
|
which split scsi_dma_restart_bh(), but the object_unref() belongs to
|
|
scsi_dma_restart_bh().
|
|
So, we should mv object_unref() from scsi_retry_requests() to
|
|
scsi_dma_restart_bh().
|
|
|
|
Signed-off-by: Yan Wang <wangyan122@huawei.com>
|
|
Signed-off-by: shaodenghui <shaodenghui@huawei.com>
|
|
---
|
|
hw/scsi/scsi-bus.c | 5 +++--
|
|
1 file changed, 3 insertions(+), 2 deletions(-)
|
|
|
|
diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c
|
|
index cecb02ae7e..7b60ac11f5 100644
|
|
--- a/hw/scsi/scsi-bus.c
|
|
+++ b/hw/scsi/scsi-bus.c
|
|
@@ -167,8 +167,6 @@ void scsi_retry_requests(SCSIDevice *s)
|
|
scsi_req_unref(req);
|
|
}
|
|
aio_context_release(blk_get_aio_context(s->conf.blk));
|
|
- /* Drop the reference that was acquired in scsi_dma_restart_cb */
|
|
- object_unref(OBJECT(s));
|
|
}
|
|
|
|
static void scsi_dma_restart_bh(void *opaque)
|
|
@@ -179,6 +177,9 @@ static void scsi_dma_restart_bh(void *opaque)
|
|
s->bh = NULL;
|
|
|
|
scsi_retry_requests(s);
|
|
+
|
|
+ /* Drop the reference that was acquired in scsi_dma_restart_cb */
|
|
+ object_unref(OBJECT(s));
|
|
}
|
|
|
|
void scsi_req_retry(SCSIRequest *req)
|
|
--
|
|
2.27.0
|
|
|