7a16948063
- ppc/xive: Fix ESB length overflow on 32-bit hosts - target/hppa: Fix PSW V-bit packaging in cpu_hppa_get for hppa64 - target/ppc: Fix migration of CPUs with TLB_EMB TLB type - target/arm: Clear high SVE elements in handle_vec_simd_wshli - module: Prevent crash by resetting local_err in module_load_qom_all() - tests/docker: update debian i686 and mipsel images to bookworm - target/arm: Fix SVE SDOT/UDOT/USDOT (4-way, indexed) - docs/sphinx/depfile.py: Handle env.doc2path() returning a Path not a str - block/blkio: use FUA flag on write zeroes only if supported - virtio-pci: Fix the use of an uninitialized irqfd - hw/cxl: Ensure there is enough data to read the input header in cmd_get_physical_port_state() - intel_iommu: Send IQE event when setting reserved bit in IQT_TAIL - virtio-net: Avoid indirection_table_mask overflow - Fix calculation of minimum in colo_compare_tcp - target/riscv/csr.c: Fix an access to VXSAT - linux-user: Clean up unused header - raw-format: Fix error message for invalid offset/size - hw/loongarch/virt: Remove unnecessary 'cpu.h' inclusion - tests: Wait for migration completion on destination QEMU to avoid failures - acpi: ged: Add macro for acpi sleep control register - hw/intc/openpic: Improve errors for out of bounds property values - hw/pci-bridge: Add a Kconfig switch for the normal PCI bridge - docs/tools/qemu-img.rst: fix typo (sumarizes) - audio/pw: Report more accurate error when connecting to PipeWire fails - audio/pw: Report more accurate error when connecting to PipeWire fails - dma: Fix function names in documentation Ensure the function names match. - edu: fix DMA range upper bound check - platform-bus: fix refcount leak - hw/net/can/sja1000: fix bug for single acceptance filter and standard frame - tests/avocado: fix typo in replay_linux - util/userfaultfd: Remove unused uffd_poll_events - Consider discard option when writing zeros - crypto: factor out conversion of QAPI to gcrypt constants - crypto: drop gnutls debug logging support - crypto: use consistent error reporting pattern for unsupported cipher modes - hw/gpio/aspeed_gpio: Avoid shift into sign bit Signed-off-by: Jiabo Feng <fengjiabo1@huawei.com> (cherry picked from commit b6e04df301d30895427ab41a1edff0f40149bdd9)
43 lines
1.5 KiB
Diff
43 lines
1.5 KiB
Diff
From 0b23e1ad9e27fa60525b3d014da0425d2c24885f Mon Sep 17 00:00:00 2001
|
|
From: Zhang Jiao <zhangjiao2_yewu@cmss.chinamobile.com>
|
|
Date: Thu, 17 Oct 2024 13:19:51 +0800
|
|
Subject: [PATCH] platform-bus: fix refcount leak
|
|
|
|
cheery-pick from 99ec7b440a1d6a6ef07450b68687d24d13a25fb5
|
|
|
|
memory_region_find() returns an MR which it is the caller's
|
|
responsibility to unref, but platform_bus_map_mmio() was
|
|
forgetting to do so, thus leaking the MR.
|
|
|
|
Signed-off-by: Gao Shiyuan gaoshiyuan@baidu.com
|
|
Message-id: 20240829131005.9196-1-gaoshiyuan@baidu.com
|
|
Reviewed-by: Peter Maydell peter.maydell@linaro.org
|
|
[PMM: tweaked commit message]
|
|
Signed-off-by: Peter Maydell peter.maydell@linaro.org
|
|
Signed-off-by: Zhang Jiao <zhangjiao2_yewu@cmss.chinamobile.com>
|
|
---
|
|
hw/core/platform-bus.c | 5 ++++-
|
|
1 file changed, 4 insertions(+), 1 deletion(-)
|
|
|
|
diff --git a/hw/core/platform-bus.c b/hw/core/platform-bus.c
|
|
index b8487b26b6..dc58bf505a 100644
|
|
--- a/hw/core/platform-bus.c
|
|
+++ b/hw/core/platform-bus.c
|
|
@@ -145,9 +145,12 @@ static void platform_bus_map_mmio(PlatformBusDevice *pbus, SysBusDevice *sbdev,
|
|
* the target device's memory region
|
|
*/
|
|
for (off = 0; off < pbus->mmio_size; off += alignment) {
|
|
- if (!memory_region_find(&pbus->mmio, off, size).mr) {
|
|
+ MemoryRegion *mr = memory_region_find(&pbus->mmio, off, size).mr;
|
|
+ if (!mr) {
|
|
found_region = true;
|
|
break;
|
|
+ } else {
|
|
+ memory_region_unref(mr);
|
|
}
|
|
}
|
|
|
|
--
|
|
2.41.0.windows.1
|
|
|