d01be9927c
This series is an attempt to provide device memory hotplug support on ARM virt platform. This is based on Eric's recent works here[1] and carries some of the pc-dimm related patches dropped from his series. The kernel support for arm64 memory hot add was added recently by Robin and hence the guest kernel should be => 5.0-rc1. NVDIM support is not included currently as we still have an unresolved issue while hot adding NVDIMM[2]. However NVDIMM cold plug patches can be included, but not done for now, for keeping it simple. This makes use of GED device to sent hotplug ACPI events to the Guest. GED code is based on Nemu. Thanks to the efforts of Samuel and Sebastien to add the hardware-reduced support to Nemu using GED device[3]. (Please shout if I got the author/signed-off wrong for those patches or missed any names). This is sanity tested on a HiSilicon ARM64 platform and appreciate any further testing. Note: Attempted adding dimm_pxm test case to bios-tables-test for arm/virt. But noticed the issue decribed here[5]. This is under investigation now. upstream url: https://patchwork.kernel.org/cover/11150345/ Signed-off-by: Keqian Zhu <zhukeqian1@huawei.com>
47 lines
1.8 KiB
Diff
47 lines
1.8 KiB
Diff
From 7a08983315bf4d624966a89112259e2b4949de91 Mon Sep 17 00:00:00 2001
|
|
From: Samuel Ortiz <sameo@linux.intel.com>
|
|
Date: Wed, 18 Sep 2019 14:06:24 +0100
|
|
Subject: [PATCH] hw/acpi: Do not create memory hotplug method when handler is
|
|
not defined
|
|
|
|
With Hardware-reduced ACPI, the GED device will manage ACPI
|
|
hotplug entirely. As a consequence, make the memory specific
|
|
events AML generation optional. The code will only be added
|
|
when the method name is not NULL.
|
|
|
|
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
|
|
Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
|
|
Reviewed-by: Eric Auger <eric.auger@redhat.com>
|
|
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
|
|
Message-Id: <20190918130633.4872-3-shameerali.kolothum.thodi@huawei.com>
|
|
Acked-by: Peter Maydell <peter.maydell@linaro.org>
|
|
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
|
|
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
|
|
---
|
|
hw/acpi/memory_hotplug.c | 10 ++++++----
|
|
1 file changed, 6 insertions(+), 4 deletions(-)
|
|
|
|
diff --git a/hw/acpi/memory_hotplug.c b/hw/acpi/memory_hotplug.c
|
|
index 9a515c0484..8b30356c1a 100644
|
|
--- a/hw/acpi/memory_hotplug.c
|
|
+++ b/hw/acpi/memory_hotplug.c
|
|
@@ -711,10 +711,12 @@ void build_memory_hotplug_aml(Aml *table, uint32_t nr_mem,
|
|
}
|
|
aml_append(table, dev_container);
|
|
|
|
- method = aml_method(event_handler_method, 0, AML_NOTSERIALIZED);
|
|
- aml_append(method,
|
|
- aml_call0(MEMORY_DEVICES_CONTAINER "." MEMORY_SLOT_SCAN_METHOD));
|
|
- aml_append(table, method);
|
|
+ if (event_handler_method) {
|
|
+ method = aml_method(event_handler_method, 0, AML_NOTSERIALIZED);
|
|
+ aml_append(method, aml_call0(MEMORY_DEVICES_CONTAINER "."
|
|
+ MEMORY_SLOT_SCAN_METHOD));
|
|
+ aml_append(table, method);
|
|
+ }
|
|
|
|
g_free(mhp_res_path);
|
|
}
|
|
--
|
|
2.19.1
|