39a0a891d8
- vdpa: move memory listener to the realize stage - vdpa: implement vdpa device migration - vhost: implement post resume bh - vhost: implement migration state notifier for vdpa device - vhost: implement savevm_hanlder for vdpa device - vhost: implement vhost_vdpa_device_suspend/resume - vhost: implement vhost-vdpa suspend/resume - vhost: add vhost_dev_suspend/resume_op - vhost: introduce bytemap for vhost backend logging - vhost-vdpa: add migration log ops for VhostOps - vhost-vdpa: add VHOST_BACKEND_F_BYTEMAPLOG - vhost: fix null pointer access - ui/gtk: prevent ui lock up when dpy_gl_update called again before current draw event occurs - hw/usb: dev-mtp: Use g_mkdir() - target/ppc/cpu-models: Remove the "default" CPU alias - hw/intc/arm_gicv3: ICC_PMR_EL1 high bits should be RAZ - Fixed a QEMU hang when guest poweroff in COLO mode - migration/colo: More accurate update checkpoint time - scripts/entitlement.sh: Use backward-compatible cp flags - block/nvme: fix infinite loop in nvme_free_req_queue_cb() - hw/net: npcm7xx_emc fix missing queue_flush - Add dummy Aspeed AST2600 Display Port MCU (DPMCU) - hw/arm: ast2600: Fix address mapping of second SPI controller - vhost-user-blk: reconnect on any error during realize - vhost-user-blk: propagate error return from generic vhost - hw/riscv: boot: Reduce FDT address alignment constraints - Revert "hw/virtio/virtio-iommu-pci: Enforce the device is plugged on the root bus" - Fix STM32F2XX USART data register readout - block: use 'unsigned' for in_flight field on driver state - sphinx: change default language to 'en' - tests/qtest: Fix two format strings - trivial typos: namesapce - hw/ide/atapi.c: Correct typos (CD-CDROM -> CD-ROM) - hw/virtio/virtio-iommu-pci: Enforce the device is plugged on the root bus - hw/display/next-fb: Fix comment typo - xen/pass-through: merge emulated bits correctly mainline inclusion commit be9c61da9fc57eb7d293f380d0805ca6f46c2657 category: bugfix - tests/qtest/migration-test.c: spelling fix: bandwith - target/i386/cpu: Improve error message for property "vendor" - balloon: Fix a misleading error message - target/arm: Don't set syndrome ISS for loads and stores with writeback mainline inclusion commit 53ae2fdef1f5661cbaa2ea571c517f98e6041cb8 category: bugfix - disas/hppa: Show hexcode of instruction along with disassembly - tcg/loongarch64: Fix tcg_out_mov() Aborted - ui/qmp-cmds: Improve two error messages - qga: Improve guest-exec-status error message - hmp: Improve sync-profile error message - spapr/pci: Correct "does not support hotplugging error messages - xen/pass-through: don't create needless register group mainline inclusion commit c0e86b7624cb9d6db03e0d48cf82659e5b89a6a6 category: bugfix Signed-off-by: Jiabo Feng <fengjiabo1@huawei.com>
61 lines
1.9 KiB
Diff
61 lines
1.9 KiB
Diff
From 0c24a55d582e8219b64f2090cbdd21027d496bb1 Mon Sep 17 00:00:00 2001
|
|
From: boringandboring <wangjinlei_yewu@cmss.chinamobile.com>
|
|
Date: Mon, 27 Nov 2023 10:44:31 +0800
|
|
Subject: [PATCH] balloon: Fix a misleading error message
|
|
|
|
cherry picked from eeef44b3a583637265f602882a0d058a52e3a33b
|
|
|
|
The error message
|
|
|
|
{"execute": "balloon", "arguments":{"value": -1}}
|
|
{"error": {"class": "GenericError", "desc": "Parameter 'target' expects a size"}}
|
|
|
|
points to 'target' instead of 'value'. Fix:
|
|
|
|
{"error": {"class": "GenericError", "desc": "Parameter 'value' expects a size"}}
|
|
|
|
Root cause: qmp_balloon()'s parameter is named @target. Rename it to
|
|
@value to match the QAPI schema.
|
|
|
|
Signed-off-by: Markus Armbruster <armbru@redhat.com>
|
|
Message-ID: <20231031111059.3407803-7-armbru@redhat.com>
|
|
Reviewed-by: David Hildenbrand <david@redhat.com>
|
|
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
|
|
Tested-by: Mario Casquero <mcasquer@redhat.com>
|
|
|
|
Signed-off-by: boringandboring <wangjinlei_yewu@cmss.chinamobile.com>
|
|
---
|
|
softmmu/balloon.c | 10 +++++-----
|
|
1 file changed, 5 insertions(+), 5 deletions(-)
|
|
|
|
diff --git a/softmmu/balloon.c b/softmmu/balloon.c
|
|
index e0e8969a4b..fda7af832e 100644
|
|
--- a/softmmu/balloon.c
|
|
+++ b/softmmu/balloon.c
|
|
@@ -90,17 +90,17 @@ BalloonInfo *qmp_query_balloon(Error **errp)
|
|
return info;
|
|
}
|
|
|
|
-void qmp_balloon(int64_t target, Error **errp)
|
|
+void qmp_balloon(int64_t value, Error **errp)
|
|
{
|
|
if (!have_balloon(errp)) {
|
|
return;
|
|
}
|
|
|
|
- if (target <= 0) {
|
|
- error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "target", "a size");
|
|
+ if (value <= 0) {
|
|
+ error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "value", "a size");
|
|
return;
|
|
}
|
|
|
|
- trace_balloon_event(balloon_opaque, target);
|
|
- balloon_event_fn(balloon_opaque, target);
|
|
+ trace_balloon_event(balloon_opaque, value);
|
|
+ balloon_event_fn(balloon_opaque, value);
|
|
}
|
|
--
|
|
2.27.0
|
|
|