f2ed4aa869
- hw/arm/virt:Keep Guest L1 cache type consistent with KVM - cvm : Add support for TEE-based national encryption acceleration. - Add virtCCA Coda annotation Adjust the position of the security device - target/i386: sev: Add support for reuse ASID for different CSV guests - target/i386: sev: Fix incompatibility between SEV and CSV on the GET_ID API - hw/cxl: Ensure there is enough data for the header in cmd_ccls_set_lsa() - hw/pci: Add parenthesis to PCI_BUILD_BDF macro - hw/audio/hda: free timer on exit - meson.build: Remove ncurses workaround for OpenBSD - ui/console-vc: Silence warning about sprintf() on OpenBSD - ui: remove break after g_assert_not_reached() - s390x/sclp: Simplify get_sclp_device() - hw/vfio/hct: qemu startup terminate once error happened in hct - hw/vfio/hct: fix ccp_index error caused by uninitialized buf - hw/vfio/hct: update support ccp count to 48. - hw/vfio: add device hct based on vfio. Signed-off-by: Jiabo Feng <fengjiabo1@huawei.com> (cherry picked from commit 702a9cc4e262a50f7aa6f7c9549fbc13d4cd0770)
53 lines
2.0 KiB
Diff
53 lines
2.0 KiB
Diff
From 3c108b874b8b142a42939d785d6706a44e7035d7 Mon Sep 17 00:00:00 2001
|
|
From: Roque Arcudia Hernandez <roqueh@google.com>
|
|
Date: Fri, 1 Nov 2024 21:59:23 +0000
|
|
Subject: [PATCH] hw/pci: Add parenthesis to PCI_BUILD_BDF macro
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
The bus parameter in the macro PCI_BUILD_BDF is not surrounded by
|
|
parenthesis. This can create a compile error when warnings are
|
|
treated as errors or can potentially create runtime errors due to the
|
|
operator precedence.
|
|
|
|
For instance:
|
|
|
|
file.c:x:32: error: suggest parentheses around '-' inside '<<'
|
|
[-Werror=parentheses]
|
|
171 | uint16_t bdf = PCI_BUILD_BDF(a - b, sdev->devfn);
|
|
| ~~^~~
|
|
include/hw/pci/pci.h:19:41: note: in definition of macro
|
|
'PCI_BUILD_BDF'
|
|
19 | #define PCI_BUILD_BDF(bus, devfn) ((bus << 8) | (devfn))
|
|
| ^~~
|
|
cc1: all warnings being treated as errors
|
|
|
|
Signed-off-by: Roque Arcudia Hernandez <roqueh@google.com>
|
|
Reviewed-by: Nabih Estefan <nabihestefan@google.com>
|
|
Message-Id: <20241101215923.3399311-1-roqueh@google.com>
|
|
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
|
|
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
|
|
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
|
|
Signed-off-by: Zhongrui Tang <tangzhongrui_yewu@cmss.chinamobile.com>
|
|
---
|
|
include/hw/pci/pci.h | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
|
|
index fa6313aabc..7cf7b5619a 100644
|
|
--- a/include/hw/pci/pci.h
|
|
+++ b/include/hw/pci/pci.h
|
|
@@ -15,7 +15,7 @@ extern bool pci_available;
|
|
#define PCI_BUS_NUM(x) (((x) >> 8) & 0xff)
|
|
#define PCI_SLOT(devfn) (((devfn) >> 3) & 0x1f)
|
|
#define PCI_FUNC(devfn) ((devfn) & 0x07)
|
|
-#define PCI_BUILD_BDF(bus, devfn) ((bus << 8) | (devfn))
|
|
+#define PCI_BUILD_BDF(bus, devfn) (((bus) << 8) | (devfn))
|
|
#define PCI_BDF_TO_DEVFN(x) ((x) & 0xff)
|
|
#define PCI_BUS_MAX 256
|
|
#define PCI_DEVFN_MAX 256
|
|
--
|
|
2.41.0.windows.1
|
|
|