7a16948063
- ppc/xive: Fix ESB length overflow on 32-bit hosts - target/hppa: Fix PSW V-bit packaging in cpu_hppa_get for hppa64 - target/ppc: Fix migration of CPUs with TLB_EMB TLB type - target/arm: Clear high SVE elements in handle_vec_simd_wshli - module: Prevent crash by resetting local_err in module_load_qom_all() - tests/docker: update debian i686 and mipsel images to bookworm - target/arm: Fix SVE SDOT/UDOT/USDOT (4-way, indexed) - docs/sphinx/depfile.py: Handle env.doc2path() returning a Path not a str - block/blkio: use FUA flag on write zeroes only if supported - virtio-pci: Fix the use of an uninitialized irqfd - hw/cxl: Ensure there is enough data to read the input header in cmd_get_physical_port_state() - intel_iommu: Send IQE event when setting reserved bit in IQT_TAIL - virtio-net: Avoid indirection_table_mask overflow - Fix calculation of minimum in colo_compare_tcp - target/riscv/csr.c: Fix an access to VXSAT - linux-user: Clean up unused header - raw-format: Fix error message for invalid offset/size - hw/loongarch/virt: Remove unnecessary 'cpu.h' inclusion - tests: Wait for migration completion on destination QEMU to avoid failures - acpi: ged: Add macro for acpi sleep control register - hw/intc/openpic: Improve errors for out of bounds property values - hw/pci-bridge: Add a Kconfig switch for the normal PCI bridge - docs/tools/qemu-img.rst: fix typo (sumarizes) - audio/pw: Report more accurate error when connecting to PipeWire fails - audio/pw: Report more accurate error when connecting to PipeWire fails - dma: Fix function names in documentation Ensure the function names match. - edu: fix DMA range upper bound check - platform-bus: fix refcount leak - hw/net/can/sja1000: fix bug for single acceptance filter and standard frame - tests/avocado: fix typo in replay_linux - util/userfaultfd: Remove unused uffd_poll_events - Consider discard option when writing zeros - crypto: factor out conversion of QAPI to gcrypt constants - crypto: drop gnutls debug logging support - crypto: use consistent error reporting pattern for unsupported cipher modes - hw/gpio/aspeed_gpio: Avoid shift into sign bit Signed-off-by: Jiabo Feng <fengjiabo1@huawei.com> (cherry picked from commit b6e04df301d30895427ab41a1edff0f40149bdd9)
37 lines
1.3 KiB
Diff
37 lines
1.3 KiB
Diff
From 10794f7a9bc3c88c8a26f094e5d3ef42e9fd290f Mon Sep 17 00:00:00 2001
|
|
From: =?UTF-8?q?=E5=BC=A0=E6=A5=9A=E5=90=9B?=
|
|
<zhangchujun@cmss.chinamobile.com>
|
|
Date: Fri, 11 Oct 2024 14:04:54 +0800
|
|
Subject: [PATCH] hw/gpio/aspeed_gpio: Avoid shift into sign bit
|
|
|
|
In aspeed_gpio_update() we calculate "mask = 1 << gpio", where gpio can be between 0 and 31.
|
|
Coverity complains about this beacuse 1 << 31 won't fit in a signed integer.
|
|
|
|
For QEMU this isn't an error because we enable -fwrapv, but we can keep Coverity happy
|
|
by doing the shift on unsigned numbers.
|
|
|
|
Resolves: Coverity CID 1547742
|
|
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
|
|
Reviewed-by: Cedric Le Goater <clg@redhat.com>
|
|
Signed-off-by: zhangchujun <zhangchujun@cmss.chinamobile.com>
|
|
---
|
|
hw/gpio/aspeed_gpio.c | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
diff --git a/hw/gpio/aspeed_gpio.c b/hw/gpio/aspeed_gpio.c
|
|
index 1e267dd482..0fc3d4c05f 100644
|
|
--- a/hw/gpio/aspeed_gpio.c
|
|
+++ b/hw/gpio/aspeed_gpio.c
|
|
@@ -281,7 +281,7 @@ static void aspeed_gpio_update(AspeedGPIOState *s, GPIOSets *regs,
|
|
diff &= mode_mask;
|
|
if (diff) {
|
|
for (gpio = 0; gpio < ASPEED_GPIOS_PER_SET; gpio++) {
|
|
- uint32_t mask = 1 << gpio;
|
|
+ uint32_t mask = 1U << gpio;
|
|
|
|
/* If the gpio needs to be updated... */
|
|
if (!(diff & mask)) {
|
|
--
|
|
2.41.0.windows.1
|
|
|