34 lines
1.1 KiB
Diff
34 lines
1.1 KiB
Diff
From 5060ef71fa4621061101a30fa9e0d1690696c5c1 Mon Sep 17 00:00:00 2001
|
|
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
|
|
Date: Tue, 24 Mar 2020 18:59:21 +0300
|
|
Subject: [PATCH 10/14] block: fix bdrv_root_attach_child forget to unref
|
|
child_bs
|
|
|
|
bdrv_root_attach_child promises to drop child_bs reference on failure.
|
|
It does it on first handled failure path, but not on the second. Fix
|
|
that.
|
|
|
|
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
|
|
Message-Id: <20200324155921.23822-1-vsementsov@virtuozzo.com>
|
|
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|
|
Signed-off-by: Peng Liang <liangpeng10@huawei.com>
|
|
---
|
|
block.c | 1 +
|
|
1 file changed, 1 insertion(+)
|
|
|
|
diff --git a/block.c b/block.c
|
|
index e834102c87f7..38880eabf801 100644
|
|
--- a/block.c
|
|
+++ b/block.c
|
|
@@ -2399,6 +2399,7 @@ BdrvChild *bdrv_root_attach_child(BlockDriverState *child_bs,
|
|
error_propagate(errp, local_err);
|
|
g_free(child);
|
|
bdrv_abort_perm_update(child_bs);
|
|
+ bdrv_unref(child_bs);
|
|
return NULL;
|
|
}
|
|
}
|
|
--
|
|
2.26.2
|
|
|