28a1ac608d
sm501: Replace hand written implementation with pixman where possible sm501: Clean up local variables in sm501_2d_operation sm501: Use BIT(x) macro to shorten constant sm501: Shorten long variable names in sm501_2d_operation sm501: Convert printf + abort to qemu_log_mask hw/net/net_tx_pkt: fix assertion failure in net_tx_pkt_add_raw_fragment() hw/net/xgmac: Fix buffer overflow in xgmac_enet_send() Signed-off-by: Ying Fang <fangying1@huawei.com>
43 lines
1.5 KiB
Diff
43 lines
1.5 KiB
Diff
From 9f1e9012047639121eb275a4f8f5693d340e91f6 Mon Sep 17 00:00:00 2001
|
|
From: BALATON Zoltan <balaton@eik.bme.hu>
|
|
Date: Thu, 21 May 2020 21:39:44 +0200
|
|
Subject: [PATCH] sm501: Use BIT(x) macro to shorten constant
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
|
|
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
|
|
Message-id: 124bf5de8d7cf503b32b377d0445029a76bfbd49.1590089984.git.balaton@eik.bme.hu
|
|
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
|
|
---
|
|
hw/display/sm501.c | 5 ++---
|
|
1 file changed, 2 insertions(+), 3 deletions(-)
|
|
|
|
diff --git a/hw/display/sm501.c b/hw/display/sm501.c
|
|
index 51e7ccc39d..f3d11d0b23 100644
|
|
--- a/hw/display/sm501.c
|
|
+++ b/hw/display/sm501.c
|
|
@@ -701,7 +701,7 @@ static void sm501_2d_operation(SM501State *s)
|
|
{
|
|
/* obtain operation parameters */
|
|
int cmd = (s->twoD_control >> 16) & 0x1F;
|
|
- int rtl = s->twoD_control & 0x8000000;
|
|
+ int rtl = s->twoD_control & BIT(27);
|
|
int src_x = (s->twoD_source >> 16) & 0x01FFF;
|
|
int src_y = s->twoD_source & 0xFFFF;
|
|
int dst_x = (s->twoD_destination >> 16) & 0x01FFF;
|
|
@@ -751,8 +751,7 @@ static void sm501_2d_operation(SM501State *s)
|
|
}
|
|
}
|
|
|
|
- if ((s->twoD_source_base & 0x08000000) ||
|
|
- (s->twoD_destination_base & 0x08000000)) {
|
|
+ if (s->twoD_source_base & BIT(27) || s->twoD_destination_base & BIT(27)) {
|
|
qemu_log_mask(LOG_UNIMP, "sm501: only local memory is supported.\n");
|
|
return;
|
|
}
|
|
--
|
|
2.23.0
|
|
|