d01be9927c
This series is an attempt to provide device memory hotplug support on ARM virt platform. This is based on Eric's recent works here[1] and carries some of the pc-dimm related patches dropped from his series. The kernel support for arm64 memory hot add was added recently by Robin and hence the guest kernel should be => 5.0-rc1. NVDIM support is not included currently as we still have an unresolved issue while hot adding NVDIMM[2]. However NVDIMM cold plug patches can be included, but not done for now, for keeping it simple. This makes use of GED device to sent hotplug ACPI events to the Guest. GED code is based on Nemu. Thanks to the efforts of Samuel and Sebastien to add the hardware-reduced support to Nemu using GED device[3]. (Please shout if I got the author/signed-off wrong for those patches or missed any names). This is sanity tested on a HiSilicon ARM64 platform and appreciate any further testing. Note: Attempted adding dimm_pxm test case to bios-tables-test for arm/virt. But noticed the issue decribed here[5]. This is under investigation now. upstream url: https://patchwork.kernel.org/cover/11150345/ Signed-off-by: Keqian Zhu <zhukeqian1@huawei.com>
54 lines
2.0 KiB
Diff
54 lines
2.0 KiB
Diff
From d9642ad522d34f0d803a87654a2c258baf1070dd Mon Sep 17 00:00:00 2001
|
|
From: "Michael S. Tsirkin" <mst@redhat.com>
|
|
Date: Sat, 5 Oct 2019 17:25:55 -0400
|
|
Subject: [PATCH] tests: document how to update acpi tables
|
|
|
|
Looks like no one understands how to do it.
|
|
Document the process.
|
|
|
|
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
|
|
---
|
|
tests/bios-tables-test.c | 27 +++++++++++++++++++++++++++
|
|
1 file changed, 27 insertions(+)
|
|
|
|
diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c
|
|
index 5e177b7155..d47ee9be99 100644
|
|
--- a/tests/bios-tables-test.c
|
|
+++ b/tests/bios-tables-test.c
|
|
@@ -10,6 +10,33 @@
|
|
* See the COPYING file in the top-level directory.
|
|
*/
|
|
|
|
+/*
|
|
+ * How to add or update the tests:
|
|
+ * Contributor:
|
|
+ * 1. add empty files for new tables, if any, under tests/data/acpi
|
|
+ * 2. list any changed files in tests/bios-tables-test-allowed-diff.h
|
|
+ * 3. commit the above *before* making changes that affect the tables
|
|
+ * Maintainer:
|
|
+ * After 1-3 above tests will pass but ignore differences with the expected files.
|
|
+ * You will also notice that tests/bios-tables-test-allowed-diff.h lists
|
|
+ * a bunch of files. This is your hint that you need to do the below:
|
|
+ * 4. Run
|
|
+ * make check V=1
|
|
+ * this will produce a bunch of warnings about differences
|
|
+ * beween actual and expected ACPI tables. If you have IASL installed,
|
|
+ * they will also be disassembled so you can look at the disassembled
|
|
+ * output. If not - disassemble them yourself in any way you like.
|
|
+ * Look at the differences - make sure they make sense and match what the
|
|
+ * changes you are merging are supposed to do.
|
|
+ *
|
|
+ * 5. From build directory, run:
|
|
+ * $(SRC_PATH)/tests/data/acpi/rebuild-expected-aml.sh
|
|
+ * 6. Now commit any changes.
|
|
+ * 7. Before doing a pull request, make sure tests/bios-tables-test-allowed-diff.h
|
|
+ * is empty - this will ensure following changes to ACPI tables will
|
|
+ * be noticed.
|
|
+ */
|
|
+
|
|
#include "qemu/osdep.h"
|
|
#include <glib/gstdio.h>
|
|
#include "qemu-common.h"
|
|
--
|
|
2.19.1
|