From c2ec0efb903e27f83cb9a54041764f76e2e1d390 Mon Sep 17 00:00:00 2001 From: jiangdongxu Date: Fri, 11 Feb 2022 16:12:21 +0800 Subject: [PATCH 1/6] seabios: convert value of be16_to_cpu to u64 before shifting be16_to_cpu(scsi_lun->lun[i]) is 16 bits and left shifting by more than 16 will have undefined behaviour. convert it to u64 before shifting. Signed-off-by: liuxiangdong Signed-off-by: jiangdongxu --- roms/seabios/src/hw/blockcmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roms/seabios/src/hw/blockcmd.c b/roms/seabios/src/hw/blockcmd.c index 6b6fea9707..af6d33544f 100644 --- a/roms/seabios/src/hw/blockcmd.c +++ b/roms/seabios/src/hw/blockcmd.c @@ -210,7 +210,7 @@ static u64 scsilun2u64(struct scsi_lun *scsi_lun) int i; u64 ret = 0; for (i = 0; i < ARRAY_SIZE(scsi_lun->lun); i++) - ret |= be16_to_cpu(scsi_lun->lun[i]) << (16 * i); + ret |= (u64)be16_to_cpu(scsi_lun->lun[i]) << (16 * i); return ret; } -- 2.27.0