34 lines
1.1 KiB
Diff
34 lines
1.1 KiB
Diff
|
From 019526f7f7b42a7d1b8a74e1db6a8050adf9e1fb Mon Sep 17 00:00:00 2001
|
||
|
|
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
|
||
|
|
Date: Tue, 24 Mar 2020 18:36:29 +0300
|
||
|
|
Subject: [PATCH 08/14] migration/ram: fix use after free of local_err
|
||
|
|
|
||
|
|
local_err is used again in migration_bitmap_sync_precopy() after
|
||
|
|
precopy_notify(), so we must zero it. Otherwise try to set
|
||
|
|
non-NULL local_err will crash.
|
||
|
|
|
||
|
|
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
|
||
|
|
Message-Id: <20200324153630.11882-6-vsementsov@virtuozzo.com>
|
||
|
|
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
|
||
|
|
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
|
||
|
|
Signed-off-by: Peng Liang <liangpeng10@huawei.com>
|
||
|
|
---
|
||
|
|
migration/ram.c | 1 +
|
||
|
|
1 file changed, 1 insertion(+)
|
||
|
|
|
||
|
|
diff --git a/migration/ram.c b/migration/ram.c
|
||
|
|
index 840e35480b04..5d1ae7570018 100644
|
||
|
|
--- a/migration/ram.c
|
||
|
|
+++ b/migration/ram.c
|
||
|
|
@@ -1912,6 +1912,7 @@ static void migration_bitmap_sync_precopy(RAMState *rs)
|
||
|
|
*/
|
||
|
|
if (precopy_notify(PRECOPY_NOTIFY_BEFORE_BITMAP_SYNC, &local_err)) {
|
||
|
|
error_report_err(local_err);
|
||
|
|
+ local_err = NULL;
|
||
|
|
}
|
||
|
|
|
||
|
|
migration_bitmap_sync(rs);
|
||
|
|
--
|
||
|
|
2.26.2
|
||
|
|
|