53 lines
1.8 KiB
Diff
53 lines
1.8 KiB
Diff
|
From e41395594aab30a22ffaf1556d19ee623a33e6ec Mon Sep 17 00:00:00 2001
|
||
|
|
From: Susanooo <zhangchujun_yewu@cmss.chinamobile.com>
|
||
|
|
Date: Fri, 25 Oct 2024 09:33:41 +0800
|
||
|
|
Subject: [PATCH] ui/console-vc: Silence warning about sprintf() on OpenBSD
|
||
|
|
MIME-Version: 1.0
|
||
|
|
Content-Type: text/plain; charset=UTF-8
|
||
|
|
Content-Transfer-Encoding: 8bit
|
||
|
|
|
||
|
|
The linker on OpenBSD complains:
|
||
|
|
|
||
|
|
ld: warning: console-vc.c:824 (../src/ui/console-vc.c:824)([...]):
|
||
|
|
warning: sprintf() is often misused, please use snprintf()
|
||
|
|
|
||
|
|
Using g_strdup_printf() is certainly better here, so let's switch
|
||
|
|
to that function instead.
|
||
|
|
|
||
|
|
Signed-off-by: Thomas Huth <thuth@redhat.com>
|
||
|
|
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
|
||
|
|
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
|
||
|
|
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
|
||
|
|
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
|
||
|
|
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
|
||
|
|
Signed-off-by: zhangchujun <zhangchujun_yewu@cmss.chinamobile.com>
|
||
|
|
---
|
||
|
|
ui/console-vc.c | 4 ++--
|
||
|
|
1 file changed, 2 insertions(+), 2 deletions(-)
|
||
|
|
|
||
|
|
diff --git a/ui/console-vc.c b/ui/console-vc.c
|
||
|
|
index 9c13cc2981..b1903c3e48 100644
|
||
|
|
--- a/ui/console-vc.c
|
||
|
|
+++ b/ui/console-vc.c
|
||
|
|
@@ -648,7 +648,7 @@ static void vc_putchar(VCChardev *vc, int ch)
|
||
|
|
QemuTextConsole *s = vc->console;
|
||
|
|
int i;
|
||
|
|
int x, y;
|
||
|
|
- char response[40];
|
||
|
|
+ g_autofree char *response = NULL;
|
||
|
|
|
||
|
|
switch(vc->state) {
|
||
|
|
case TTY_STATE_NORM:
|
||
|
|
@@ -821,7 +821,7 @@ static void vc_putchar(VCChardev *vc, int ch)
|
||
|
|
break;
|
||
|
|
case 6:
|
||
|
|
/* report cursor position */
|
||
|
|
- sprintf(response, "\033[%d;%dR",
|
||
|
|
+ response = g_strdup_printf("\033[%d;%dR",
|
||
|
|
(s->y_base + s->y) % s->total_height + 1,
|
||
|
|
s->x + 1);
|
||
|
|
vc_respond_str(vc, response);
|
||
|
|
--
|
||
|
|
2.41.0.windows.1
|
||
|
|
|