34 lines
1.1 KiB
Diff
34 lines
1.1 KiB
Diff
|
From 663e9b5f25d22834260a0686f77a27c957cd7b2f Mon Sep 17 00:00:00 2001
|
||
|
|
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
|
||
|
|
Date: Tue, 24 Mar 2020 18:36:28 +0300
|
||
|
|
Subject: [PATCH 07/14] migration/colo: fix use after free of local_err
|
||
|
|
|
||
|
|
local_err is used again in secondary_vm_do_failover() after
|
||
|
|
replication_stop_all(), so we must zero it. Otherwise try to set
|
||
|
|
non-NULL local_err will crash.
|
||
|
|
|
||
|
|
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
|
||
|
|
Message-Id: <20200324153630.11882-5-vsementsov@virtuozzo.com>
|
||
|
|
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
|
||
|
|
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
|
||
|
|
Signed-off-by: Peng Liang <liangpeng10@huawei.com>
|
||
|
|
---
|
||
|
|
migration/colo.c | 1 +
|
||
|
|
1 file changed, 1 insertion(+)
|
||
|
|
|
||
|
|
diff --git a/migration/colo.c b/migration/colo.c
|
||
|
|
index 9f84b1fa3c0f..761b3544d472 100644
|
||
|
|
--- a/migration/colo.c
|
||
|
|
+++ b/migration/colo.c
|
||
|
|
@@ -89,6 +89,7 @@ static void secondary_vm_do_failover(void)
|
||
|
|
replication_stop_all(true, &local_err);
|
||
|
|
if (local_err) {
|
||
|
|
error_report_err(local_err);
|
||
|
|
+ local_err = NULL;
|
||
|
|
}
|
||
|
|
|
||
|
|
/* Notify all filters of all NIC to do checkpoint */
|
||
|
|
--
|
||
|
|
2.26.2
|
||
|
|
|