37 lines
1.3 KiB
Diff
37 lines
1.3 KiB
Diff
|
From 10794f7a9bc3c88c8a26f094e5d3ef42e9fd290f Mon Sep 17 00:00:00 2001
|
||
|
|
From: =?UTF-8?q?=E5=BC=A0=E6=A5=9A=E5=90=9B?=
|
||
|
|
<zhangchujun@cmss.chinamobile.com>
|
||
|
|
Date: Fri, 11 Oct 2024 14:04:54 +0800
|
||
|
|
Subject: [PATCH] hw/gpio/aspeed_gpio: Avoid shift into sign bit
|
||
|
|
|
||
|
|
In aspeed_gpio_update() we calculate "mask = 1 << gpio", where gpio can be between 0 and 31.
|
||
|
|
Coverity complains about this beacuse 1 << 31 won't fit in a signed integer.
|
||
|
|
|
||
|
|
For QEMU this isn't an error because we enable -fwrapv, but we can keep Coverity happy
|
||
|
|
by doing the shift on unsigned numbers.
|
||
|
|
|
||
|
|
Resolves: Coverity CID 1547742
|
||
|
|
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
|
||
|
|
Reviewed-by: Cedric Le Goater <clg@redhat.com>
|
||
|
|
Signed-off-by: zhangchujun <zhangchujun@cmss.chinamobile.com>
|
||
|
|
---
|
||
|
|
hw/gpio/aspeed_gpio.c | 2 +-
|
||
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||
|
|
|
||
|
|
diff --git a/hw/gpio/aspeed_gpio.c b/hw/gpio/aspeed_gpio.c
|
||
|
|
index 1e267dd482..0fc3d4c05f 100644
|
||
|
|
--- a/hw/gpio/aspeed_gpio.c
|
||
|
|
+++ b/hw/gpio/aspeed_gpio.c
|
||
|
|
@@ -281,7 +281,7 @@ static void aspeed_gpio_update(AspeedGPIOState *s, GPIOSets *regs,
|
||
|
|
diff &= mode_mask;
|
||
|
|
if (diff) {
|
||
|
|
for (gpio = 0; gpio < ASPEED_GPIOS_PER_SET; gpio++) {
|
||
|
|
- uint32_t mask = 1 << gpio;
|
||
|
|
+ uint32_t mask = 1U << gpio;
|
||
|
|
|
||
|
|
/* If the gpio needs to be updated... */
|
||
|
|
if (!(diff & mask)) {
|
||
|
|
--
|
||
|
|
2.41.0.windows.1
|
||
|
|
|