47 lines
1.6 KiB
Diff
47 lines
1.6 KiB
Diff
|
From 23ba08631691242000e60f85a9d0a67a42dcca3b Mon Sep 17 00:00:00 2001
|
||
|
|
From: tangbinzy <tangbin_yewu@cmss.chinamobile.com>
|
||
|
|
Date: Fri, 4 Aug 2023 08:26:16 +0000
|
||
|
|
Subject: [PATCH] block: Fix misleading hexadecimal format mainline inclusion
|
||
|
|
commit 3f1db95917bf0b4accaf8f56d43f795fed1fb733 category: bugfix
|
||
|
|
MIME-Version: 1.0
|
||
|
|
Content-Type: text/plain; charset=UTF-8
|
||
|
|
Content-Transfer-Encoding: 8bit
|
||
|
|
|
||
|
|
---------------------------------------------------------------
|
||
|
|
|
||
|
|
"0x%u" format is very misleading, replace by "0x%x".
|
||
|
|
|
||
|
|
Found running:
|
||
|
|
|
||
|
|
$ git grep -E '0x%[0-9]*([lL]*|" ?PRI)[dDuU]' block/
|
||
|
|
|
||
|
|
Inspired-by: Richard Henderson <richard.henderson@linaro.org>
|
||
|
|
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
|
||
|
|
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
|
||
|
|
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
|
||
|
|
Reviewed-by: Denis V. Lunev <den@openvz.org>
|
||
|
|
Message-id: 20220323114718.58714-2-philippe.mathieu.daude@gmail.com
|
||
|
|
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
|
||
|
|
|
||
|
|
Signed-off-by: tangbinzy <tangbin_yewu@cmss.chinamobile.com>
|
||
|
|
---
|
||
|
|
block/parallels-ext.c | 2 +-
|
||
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||
|
|
|
||
|
|
diff --git a/block/parallels-ext.c b/block/parallels-ext.c
|
||
|
|
index e0dd0975c6..b0e1c1aa47 100644
|
||
|
|
--- a/block/parallels-ext.c
|
||
|
|
+++ b/block/parallels-ext.c
|
||
|
|
@@ -260,7 +260,7 @@ static int parallels_parse_format_extension(BlockDriverState *bs,
|
||
|
|
break;
|
||
|
|
|
||
|
|
default:
|
||
|
|
- error_setg(errp, "Unknown feature: 0x%" PRIu64, fh.magic);
|
||
|
|
+ error_setg(errp, "Unknown feature: 0x%" PRIx64, fh.magic);
|
||
|
|
goto fail;
|
||
|
|
}
|
||
|
|
|
||
|
|
--
|
||
|
|
2.41.0.windows.1
|
||
|
|
|