78 lines
3.0 KiB
Diff
78 lines
3.0 KiB
Diff
|
From c219274b7b6a472d7340a4f72a052ba33ed19659 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Eric Auger <eric.auger@redhat.com>
|
||
|
|
Date: Thu, 14 Mar 2019 09:55:13 -0400
|
||
|
|
Subject: [PATCH] hw/arm/smmuv3: Fill the IOTLBEntry leaf field on NH_VA
|
||
|
|
invalidation
|
||
|
|
|
||
|
|
Let's propagate the leaf attribute throughout the invalidation path.
|
||
|
|
This hint is used to reduce the scope of the invalidations to the
|
||
|
|
last level of translation. Not enforcing it induces large performance
|
||
|
|
penalties in nested mode.
|
||
|
|
|
||
|
|
Signed-off-by: Eric Auger <eric.auger@redhat.com>
|
||
|
|
Signed-off-by: Kunkun Jiang <jiangkunkun@huawei.com>
|
||
|
|
---
|
||
|
|
hw/arm/smmuv3.c | 11 ++++++-----
|
||
|
|
1 file changed, 6 insertions(+), 5 deletions(-)
|
||
|
|
|
||
|
|
diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c
|
||
|
|
index 696c588f08..ad816e850c 100644
|
||
|
|
--- a/hw/arm/smmuv3.c
|
||
|
|
+++ b/hw/arm/smmuv3.c
|
||
|
|
@@ -800,7 +800,7 @@ epilogue:
|
||
|
|
static void smmuv3_notify_iova(IOMMUMemoryRegion *mr,
|
||
|
|
IOMMUNotifier *n,
|
||
|
|
int asid, dma_addr_t iova,
|
||
|
|
- uint8_t tg, uint64_t num_pages)
|
||
|
|
+ uint8_t tg, uint64_t num_pages, bool leaf)
|
||
|
|
{
|
||
|
|
SMMUDevice *sdev = container_of(mr, SMMUDevice, iommu);
|
||
|
|
IOMMUTLBEvent event = {};
|
||
|
|
@@ -835,6 +835,7 @@ static void smmuv3_notify_iova(IOMMUMemoryRegion *mr,
|
||
|
|
event.entry.perm = IOMMU_NONE;
|
||
|
|
event.entry.flags = IOMMU_INV_FLAGS_ARCHID;
|
||
|
|
event.entry.arch_id = asid;
|
||
|
|
+ event.entry.leaf = leaf;
|
||
|
|
|
||
|
|
memory_region_notify_iommu_one(n, &event);
|
||
|
|
}
|
||
|
|
@@ -866,7 +867,7 @@ static void smmuv3_notify_asid(IOMMUMemoryRegion *mr,
|
||
|
|
|
||
|
|
/* invalidate an asid/iova range tuple in all mr's */
|
||
|
|
static void smmuv3_inv_notifiers_iova(SMMUState *s, int asid, dma_addr_t iova,
|
||
|
|
- uint8_t tg, uint64_t num_pages)
|
||
|
|
+ uint8_t tg, uint64_t num_pages, bool leaf)
|
||
|
|
{
|
||
|
|
SMMUDevice *sdev;
|
||
|
|
|
||
|
|
@@ -878,7 +879,7 @@ static void smmuv3_inv_notifiers_iova(SMMUState *s, int asid, dma_addr_t iova,
|
||
|
|
tg, num_pages);
|
||
|
|
|
||
|
|
IOMMU_NOTIFIER_FOREACH(n, mr) {
|
||
|
|
- smmuv3_notify_iova(mr, n, asid, iova, tg, num_pages);
|
||
|
|
+ smmuv3_notify_iova(mr, n, asid, iova, tg, num_pages, leaf);
|
||
|
|
}
|
||
|
|
}
|
||
|
|
}
|
||
|
|
@@ -903,7 +904,7 @@ static void smmuv3_s1_range_inval(SMMUState *s, Cmd *cmd)
|
||
|
|
|
||
|
|
if (!tg) {
|
||
|
|
trace_smmuv3_s1_range_inval(vmid, asid, addr, tg, 1, ttl, leaf);
|
||
|
|
- smmuv3_inv_notifiers_iova(s, asid, addr, tg, 1);
|
||
|
|
+ smmuv3_inv_notifiers_iova(s, asid, addr, tg, 1, leaf);
|
||
|
|
smmu_iotlb_inv_iova(s, asid, addr, tg, 1, ttl);
|
||
|
|
return;
|
||
|
|
}
|
||
|
|
@@ -921,7 +922,7 @@ static void smmuv3_s1_range_inval(SMMUState *s, Cmd *cmd)
|
||
|
|
|
||
|
|
num_pages = (mask + 1) >> granule;
|
||
|
|
trace_smmuv3_s1_range_inval(vmid, asid, addr, tg, num_pages, ttl, leaf);
|
||
|
|
- smmuv3_inv_notifiers_iova(s, asid, addr, tg, num_pages);
|
||
|
|
+ smmuv3_inv_notifiers_iova(s, asid, addr, tg, num_pages, leaf);
|
||
|
|
smmu_iotlb_inv_iova(s, asid, addr, tg, num_pages, ttl);
|
||
|
|
addr += mask + 1;
|
||
|
|
}
|
||
|
|
--
|
||
|
|
2.27.0
|
||
|
|
|