50 lines
1.7 KiB
Diff
50 lines
1.7 KiB
Diff
|
From a089328f183371ec7f7cd641f46beeeea2c9decc Mon Sep 17 00:00:00 2001
|
||
|
|
From: Si-Wei Liu <si-wei.liu@oracle.com>
|
||
|
|
Date: Fri, 6 May 2022 19:28:16 -0700
|
||
|
|
Subject: [PATCH] vhost-vdpa: backend feature should set only once
|
||
|
|
MIME-Version: 1.0
|
||
|
|
Content-Type: text/plain; charset=UTF-8
|
||
|
|
Content-Transfer-Encoding: 8bit
|
||
|
|
|
||
|
|
The vhost_vdpa_one_time_request() branch in
|
||
|
|
vhost_vdpa_set_backend_cap() incorrectly sends down
|
||
|
|
ioctls on vhost_dev with non-zero index. This may
|
||
|
|
end up with multiple VHOST_SET_BACKEND_FEATURES
|
||
|
|
ioctl calls sent down on the vhost-vdpa fd that is
|
||
|
|
shared between all these vhost_dev's.
|
||
|
|
|
||
|
|
To fix it, send down ioctl only once via the first
|
||
|
|
vhost_dev with index 0. Toggle the polarity of the
|
||
|
|
vhost_vdpa_one_time_request() test should do the
|
||
|
|
trick.
|
||
|
|
|
||
|
|
Fixes: 4d191cfdc7de ("vhost-vdpa: classify one time request")
|
||
|
|
Signed-off-by: Si-Wei Liu <si-wei.liu@oracle.com>
|
||
|
|
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
|
||
|
|
Acked-by: Jason Wang <jasowang@redhat.com>
|
||
|
|
Acked-by: Eugenio Pérez <eperezma@redhat.com>
|
||
|
|
Message-Id: <1651890498-24478-6-git-send-email-si-wei.liu@oracle.com>
|
||
|
|
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
|
||
|
|
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
|
||
|
|
Signed-off-by: fangyi <eric.fangyi@huawei.com>
|
||
|
|
---
|
||
|
|
hw/virtio/vhost-vdpa.c | 2 +-
|
||
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||
|
|
|
||
|
|
diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
|
||
|
|
index 1360f2eaf7..cb74d71b80 100644
|
||
|
|
--- a/hw/virtio/vhost-vdpa.c
|
||
|
|
+++ b/hw/virtio/vhost-vdpa.c
|
||
|
|
@@ -669,7 +669,7 @@ static int vhost_vdpa_set_backend_cap(struct vhost_dev *dev)
|
||
|
|
|
||
|
|
features &= f;
|
||
|
|
|
||
|
|
- if (vhost_vdpa_one_time_request(dev)) {
|
||
|
|
+ if (!vhost_vdpa_one_time_request(dev)) {
|
||
|
|
r = vhost_vdpa_call(dev, VHOST_SET_BACKEND_FEATURES, &features);
|
||
|
|
if (r) {
|
||
|
|
return -EFAULT;
|
||
|
|
--
|
||
|
|
2.27.0
|
||
|
|
|