70 lines
1.8 KiB
Diff
70 lines
1.8 KiB
Diff
|
|
From 5bf30b401a5fa16189589381d42bfc5f6cf8cf9c Mon Sep 17 00:00:00 2001
|
||
|
|
From: =?UTF-8?q?Eugenio=20P=C3=A9rez?= <eperezma@redhat.com>
|
||
|
|
Date: Wed, 20 Jul 2022 08:59:30 +0200
|
||
|
|
Subject: [PATCH] vhost: Reorder vhost_svq_kick
|
||
|
|
MIME-Version: 1.0
|
||
|
|
Content-Type: text/plain; charset=UTF-8
|
||
|
|
Content-Transfer-Encoding: 8bit
|
||
|
|
|
||
|
|
Future code needs to call it from vhost_svq_add.
|
||
|
|
|
||
|
|
No functional change intended.
|
||
|
|
|
||
|
|
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
|
||
|
|
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
|
||
|
|
Signed-off-by: Jason Wang <jasowang@redhat.com>
|
||
|
|
Signed-off-by: fangyi <eric.fangyi@huawei.com>
|
||
|
|
---
|
||
|
|
hw/virtio/vhost-shadow-virtqueue.c | 28 ++++++++++++++--------------
|
||
|
|
1 file changed, 14 insertions(+), 14 deletions(-)
|
||
|
|
|
||
|
|
diff --git a/hw/virtio/vhost-shadow-virtqueue.c b/hw/virtio/vhost-shadow-virtqueue.c
|
||
|
|
index acf50a9a0b..1ba863b802 100644
|
||
|
|
--- a/hw/virtio/vhost-shadow-virtqueue.c
|
||
|
|
+++ b/hw/virtio/vhost-shadow-virtqueue.c
|
||
|
|
@@ -214,6 +214,20 @@ static bool vhost_svq_add_split(VhostShadowVirtqueue *svq,
|
||
|
|
return true;
|
||
|
|
}
|
||
|
|
|
||
|
|
+static void vhost_svq_kick(VhostShadowVirtqueue *svq)
|
||
|
|
+{
|
||
|
|
+ /*
|
||
|
|
+ * We need to expose the available array entries before checking the used
|
||
|
|
+ * flags
|
||
|
|
+ */
|
||
|
|
+ smp_mb();
|
||
|
|
+ if (svq->vring.used->flags & VRING_USED_F_NO_NOTIFY) {
|
||
|
|
+ return;
|
||
|
|
+ }
|
||
|
|
+
|
||
|
|
+ event_notifier_set(&svq->hdev_kick);
|
||
|
|
+}
|
||
|
|
+
|
||
|
|
/**
|
||
|
|
* Add an element to a SVQ.
|
||
|
|
*
|
||
|
|
@@ -234,20 +248,6 @@ static bool vhost_svq_add(VhostShadowVirtqueue *svq, VirtQueueElement *elem)
|
||
|
|
return true;
|
||
|
|
}
|
||
|
|
|
||
|
|
-static void vhost_svq_kick(VhostShadowVirtqueue *svq)
|
||
|
|
-{
|
||
|
|
- /*
|
||
|
|
- * We need to expose the available array entries before checking the used
|
||
|
|
- * flags
|
||
|
|
- */
|
||
|
|
- smp_mb();
|
||
|
|
- if (svq->vring.used->flags & VRING_USED_F_NO_NOTIFY) {
|
||
|
|
- return;
|
||
|
|
- }
|
||
|
|
-
|
||
|
|
- event_notifier_set(&svq->hdev_kick);
|
||
|
|
-}
|
||
|
|
-
|
||
|
|
/**
|
||
|
|
* Forward available buffers.
|
||
|
|
*
|
||
|
|
--
|
||
|
|
2.27.0
|
||
|
|
|