63 lines
2.3 KiB
Diff
63 lines
2.3 KiB
Diff
|
From 1c9d6dde6fabf6c1f6a4aeb388921a83279d3071 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Hawkins Jiawei <yin31149@gmail.com>
|
||
|
|
Date: Tue, 4 Jul 2023 11:34:33 +0800
|
||
|
|
Subject: [PATCH] vdpa: Return -EIO if device ack is VIRTIO_NET_ERR in
|
||
|
|
_load_mac()
|
||
|
|
MIME-Version: 1.0
|
||
|
|
Content-Type: text/plain; charset=UTF-8
|
||
|
|
Content-Transfer-Encoding: 8bit
|
||
|
|
|
||
|
|
According to VirtIO standard, "The class, command and
|
||
|
|
command-specific-data are set by the driver,
|
||
|
|
and the device sets the ack byte.
|
||
|
|
There is little it can do except issue a diagnostic
|
||
|
|
if ack is not VIRTIO_NET_OK."
|
||
|
|
|
||
|
|
Therefore, QEMU should stop sending the queued SVQ commands and
|
||
|
|
cancel the device startup if the device's ack is not VIRTIO_NET_OK.
|
||
|
|
|
||
|
|
Yet the problem is that, vhost_vdpa_net_load_mac() returns 1 based on
|
||
|
|
`*s->status != VIRTIO_NET_OK` when the device's ack is VIRTIO_NET_ERR.
|
||
|
|
As a result, net->nc->info->load() also returns 1, this makes
|
||
|
|
vhost_net_start_one() incorrectly assume the device state is
|
||
|
|
successfully loaded by vhost_vdpa_net_load() and return 0, instead of
|
||
|
|
goto `fail` label to cancel the device startup, as vhost_net_start_one()
|
||
|
|
only cancels the device startup when net->nc->info->load() returns a
|
||
|
|
negative value.
|
||
|
|
|
||
|
|
This patch fixes this problem by returning -EIO when the device's
|
||
|
|
ack is not VIRTIO_NET_OK.
|
||
|
|
|
||
|
|
Fixes: f73c0c43ac ("vdpa: extract vhost_vdpa_net_load_mac from vhost_vdpa_net_load")
|
||
|
|
Signed-off-by: Hawkins Jiawei <yin31149@gmail.com>
|
||
|
|
Acked-by: Jason Wang <jasowang@redhat.com>
|
||
|
|
Acked-by: Eugenio Pérez <eperezma@redhat.com>
|
||
|
|
Message-Id: <a21731518644abbd0c495c5b7960527c5911f80d.1688438055.git.yin31149@gmail.com>
|
||
|
|
Tested-by: Lei Yang <leiyang@redhat.com>
|
||
|
|
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
|
||
|
|
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
|
||
|
|
Signed-off-by: fangyi <eric.fangyi@huawei.com>
|
||
|
|
---
|
||
|
|
net/vhost-vdpa.c | 5 +++--
|
||
|
|
1 file changed, 3 insertions(+), 2 deletions(-)
|
||
|
|
|
||
|
|
diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
|
||
|
|
index afca8740bc..9af9f6554e 100644
|
||
|
|
--- a/net/vhost-vdpa.c
|
||
|
|
+++ b/net/vhost-vdpa.c
|
||
|
|
@@ -527,8 +527,9 @@ static int vhost_vdpa_net_load_mac(VhostVDPAState *s, const VirtIONet *n)
|
||
|
|
if (unlikely(dev_written < 0)) {
|
||
|
|
return dev_written;
|
||
|
|
}
|
||
|
|
-
|
||
|
|
- return *s->status != VIRTIO_NET_OK;
|
||
|
|
+ if (*s->status != VIRTIO_NET_OK) {
|
||
|
|
+ return -EIO;
|
||
|
|
+ }
|
||
|
|
}
|
||
|
|
|
||
|
|
return 0;
|
||
|
|
--
|
||
|
|
2.27.0
|
||
|
|
|