44 lines
1.7 KiB
Diff
44 lines
1.7 KiB
Diff
|
|
From fb63e3343eaaf1d5aaf0a28e2f3ed2248a11e86a Mon Sep 17 00:00:00 2001
|
||
|
|
From: xiaowanghe <xiaowanghe_yewu@cmss.chinamobile.com>
|
||
|
|
Date: Mon, 7 Aug 2023 00:28:14 -0700
|
||
|
|
Subject: [PATCH] qapi: support updating expected test output via make
|
||
|
|
MIME-Version: 1.0
|
||
|
|
Content-Type: text/plain; charset=UTF-8
|
||
|
|
Content-Transfer-Encoding: 8bit
|
||
|
|
|
||
|
|
cherry picked from commit 7ce54db23048bfcc3ea6821525bf333b715c7655
|
||
|
|
|
||
|
|
It is possible to pass --update to tests/qapi-schema/test-qapi.py
|
||
|
|
to make it update the output files on error. This is inconvenient
|
||
|
|
to achieve though when test-qapi.py is run indirectly by make/meson.
|
||
|
|
|
||
|
|
Instead simply allow for an env variable to be set:
|
||
|
|
|
||
|
|
$ QAPI_TEST_UPDATE= make check-qapi-schema
|
||
|
|
|
||
|
|
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
|
||
|
|
Message-Id: <20230420102619.348173-2-berrange@redhat.com>
|
||
|
|
Reviewed-by: Markus Armbruster <armbru@redhat.com>
|
||
|
|
Signed-off-by: Markus Armbruster <armbru@redhat.com>
|
||
|
|
|
||
|
|
Signed-off-by: Wanghe Xiao <xiaowanghe_yewu@cmss.chinamobile.com>
|
||
|
|
---
|
||
|
|
tests/qapi-schema/test-qapi.py | 1 +
|
||
|
|
1 file changed, 1 insertion(+)
|
||
|
|
|
||
|
|
diff --git a/tests/qapi-schema/test-qapi.py b/tests/qapi-schema/test-qapi.py
|
||
|
|
index 2160cef082..d58c31f539 100755
|
||
|
|
--- a/tests/qapi-schema/test-qapi.py
|
||
|
|
+++ b/tests/qapi-schema/test-qapi.py
|
||
|
|
@@ -206,6 +206,7 @@ def main(argv):
|
||
|
|
parser.add_argument('-d', '--dir', action='store', default='',
|
||
|
|
help="directory containing tests")
|
||
|
|
parser.add_argument('-u', '--update', action='store_true',
|
||
|
|
+ default='QAPI_TEST_UPDATE' in os.environ,
|
||
|
|
help="update expected test results")
|
||
|
|
parser.add_argument('tests', nargs='*', metavar='TEST', action='store')
|
||
|
|
args = parser.parse_args()
|
||
|
|
--
|
||
|
|
2.41.0.windows.1
|
||
|
|
|