37 lines
1.1 KiB
Diff
37 lines
1.1 KiB
Diff
|
From ddd117ccb7dfc57dcd45d52d35cd71f746d81c3a Mon Sep 17 00:00:00 2001
|
||
|
|
From: Si-Wei Liu <si-wei.liu@oracle.com>
|
||
|
|
Date: Fri, 6 May 2022 19:28:14 -0700
|
||
|
|
Subject: [PATCH] vhost-vdpa: fix improper cleanup in net_init_vhost_vdpa
|
||
|
|
|
||
|
|
... such that no memory leaks on dangling net clients in case of
|
||
|
|
error.
|
||
|
|
|
||
|
|
Signed-off-by: Si-Wei Liu <si-wei.liu@oracle.com>
|
||
|
|
Acked-by: Jason Wang <jasowang@redhat.com>
|
||
|
|
Message-Id: <1651890498-24478-4-git-send-email-si-wei.liu@oracle.com>
|
||
|
|
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
|
||
|
|
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
|
||
|
|
Signed-off-by: fangyi <eric.fangyi@huawei.com>
|
||
|
|
---
|
||
|
|
net/vhost-vdpa.c | 4 +++-
|
||
|
|
1 file changed, 3 insertions(+), 1 deletion(-)
|
||
|
|
|
||
|
|
diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
|
||
|
|
index 9ba0f7bfca..7201c79116 100644
|
||
|
|
--- a/net/vhost-vdpa.c
|
||
|
|
+++ b/net/vhost-vdpa.c
|
||
|
|
@@ -314,7 +314,9 @@ int net_init_vhost_vdpa(const Netdev *netdev, const char *name,
|
||
|
|
|
||
|
|
err:
|
||
|
|
if (i) {
|
||
|
|
- qemu_del_net_client(ncs[0]);
|
||
|
|
+ for (i--; i >= 0; i--) {
|
||
|
|
+ qemu_del_net_client(ncs[i]);
|
||
|
|
+ }
|
||
|
|
}
|
||
|
|
qemu_close(vdpa_device_fd);
|
||
|
|
|
||
|
|
--
|
||
|
|
2.27.0
|
||
|
|
|