39 lines
1.3 KiB
Diff
39 lines
1.3 KiB
Diff
|
From 2fc8029b9e274a0dbedc55b6b114b29e003b32ab Mon Sep 17 00:00:00 2001
|
|||
|
|
From: =?UTF-8?q?=E5=88=98=E5=A9=A720201110?=
|
|||
|
|
<liujing_yewu@cmss.chinamobile.com>
|
|||
|
|
Date: Mon, 8 Apr 2024 04:32:11 -0400
|
|||
|
|
Subject: [PATCH] hw/nvme: fix -Werror=maybe-uninitialized
|
|||
|
|
MIME-Version: 1.0
|
|||
|
|
Content-Type: text/plain; charset=UTF-8
|
|||
|
|
Content-Transfer-Encoding: 8bit
|
|||
|
|
|
|||
|
|
../hw/nvme/ctrl.c:6081:21: error: ‘result’ may be used uninitialized [-Werror=maybe-uninitialized]
|
|||
|
|
|
|||
|
|
It's not obvious that 'result' is set in all code paths. When &result is
|
|||
|
|
a returned argument, it's even less clear.
|
|||
|
|
|
|||
|
|
Looking at various assignments, 0 seems to be a suitable default value.
|
|||
|
|
|
|||
|
|
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
|
|||
|
|
Signed-off-by: Liu Jing <liujing_yewu@cmss.chinamobile.com>
|
|||
|
|
---
|
|||
|
|
hw/nvme/ctrl.c | 2 +-
|
|||
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|||
|
|
|
|||
|
|
diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
|
|||
|
|
index 7a56e7b79b..237b5c8871 100644
|
|||
|
|
--- a/hw/nvme/ctrl.c
|
|||
|
|
+++ b/hw/nvme/ctrl.c
|
|||
|
|
@@ -5882,7 +5882,7 @@ static uint16_t nvme_get_feature(NvmeCtrl *n, NvmeRequest *req)
|
|||
|
|
uint32_t dw10 = le32_to_cpu(cmd->cdw10);
|
|||
|
|
uint32_t dw11 = le32_to_cpu(cmd->cdw11);
|
|||
|
|
uint32_t nsid = le32_to_cpu(cmd->nsid);
|
|||
|
|
- uint32_t result;
|
|||
|
|
+ uint32_t result = 0;
|
|||
|
|
uint8_t fid = NVME_GETSETFEAT_FID(dw10);
|
|||
|
|
NvmeGetFeatureSelect sel = NVME_GETFEAT_SELECT(dw10);
|
|||
|
|
uint16_t iv;
|
|||
|
|
--
|
|||
|
|
2.27.0
|
|||
|
|
|