50 lines
1.8 KiB
Diff
50 lines
1.8 KiB
Diff
|
From f8ed9dd954fbd558d549c7c2e2ab7322107218a1 Mon Sep 17 00:00:00 2001
|
||
|
|
From: dinglimin <dinglimin@cmss.chinamobile.com>
|
||
|
|
Date: Tue, 27 Feb 2024 17:40:21 +0800
|
||
|
|
Subject: [PATCH] hw/i2c/smbus_slave: Add object path on error prints
|
||
|
|
MIME-Version: 1.0
|
||
|
|
Content-Type: text/plain; charset=UTF-8
|
||
|
|
Content-Transfer-Encoding: 8bit
|
||
|
|
|
||
|
|
cheery-pick from fcc8299e29816c9b6f8d9766254fce6e8a50ee52
|
||
|
|
|
||
|
|
The current logging doesn't tell us which specific smbus device is an
|
||
|
|
error state.
|
||
|
|
|
||
|
|
Signed-off-by: Joe Komlodi <komlodi@google.com>
|
||
|
|
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
|
||
|
|
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
|
||
|
|
Message-ID: <20240202204847.2062798-3-komlodi@google.com>
|
||
|
|
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
|
||
|
|
|
||
|
|
Signed-off-by: dinglimin <dinglimin@cmss.chinamobile.com>
|
||
|
|
---
|
||
|
|
hw/i2c/smbus_slave.c | 8 ++++++--
|
||
|
|
1 file changed, 6 insertions(+), 2 deletions(-)
|
||
|
|
|
||
|
|
diff --git a/hw/i2c/smbus_slave.c b/hw/i2c/smbus_slave.c
|
||
|
|
index 2ef2c7c5f6..b35516a404 100644
|
||
|
|
--- a/hw/i2c/smbus_slave.c
|
||
|
|
+++ b/hw/i2c/smbus_slave.c
|
||
|
|
@@ -25,11 +25,15 @@
|
||
|
|
#define DPRINTF(fmt, ...) \
|
||
|
|
do { printf("smbus(%02x): " fmt , dev->i2c.address, ## __VA_ARGS__); } while (0)
|
||
|
|
#define BADF(fmt, ...) \
|
||
|
|
-do { fprintf(stderr, "smbus: error: " fmt , ## __VA_ARGS__); exit(1);} while (0)
|
||
|
|
+do { g_autofree char *qom_path = object_get_canonical_path(OBJECT(dev)); \
|
||
|
|
+ fprintf(stderr, "%s: smbus: error: " fmt , qom_path, ## __VA_ARGS__); \
|
||
|
|
+ exit(1); } while (0)
|
||
|
|
#else
|
||
|
|
#define DPRINTF(fmt, ...) do {} while(0)
|
||
|
|
#define BADF(fmt, ...) \
|
||
|
|
-do { fprintf(stderr, "smbus: error: " fmt , ## __VA_ARGS__);} while (0)
|
||
|
|
+do { g_autofree char *qom_path = object_get_canonical_path(OBJECT(dev)); \
|
||
|
|
+ fprintf(stderr, "%s: smbus: error: " fmt , qom_path, ## __VA_ARGS__); \
|
||
|
|
+ } while (0)
|
||
|
|
#endif
|
||
|
|
|
||
|
|
enum {
|
||
|
|
--
|
||
|
|
2.27.0
|
||
|
|
|