76 lines
2.5 KiB
Diff
76 lines
2.5 KiB
Diff
|
From 77bca7d51e99f8ba4d11635ff9f51615739f4d55 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Yanan Wang <wangyanan55@huawei.com>
|
||
|
|
Date: Tue, 28 Dec 2021 17:22:12 +0800
|
||
|
|
Subject: [PATCH 13/24] tests/unit/test-smp-parse: No need to explicitly zero
|
||
|
|
MachineClass members
|
||
|
|
MIME-Version: 1.0
|
||
|
|
Content-Type: text/plain; charset=UTF-8
|
||
|
|
Content-Transfer-Encoding: 8bit
|
||
|
|
|
||
|
|
The default value of the MachineClass members is 0, which
|
||
|
|
means we don't have to explicitly zero them. Also the value
|
||
|
|
of "mc->smp_props.prefer_sockets" will be taken care of by
|
||
|
|
smp_parse_test(), we don't necessarily need the statement
|
||
|
|
in machine_base_class_init() either.
|
||
|
|
|
||
|
|
Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
|
||
|
|
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
|
||
|
|
Message-Id: <20211228092221.21068-6-wangyanan55@huawei.com>
|
||
|
|
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
|
||
|
|
---
|
||
|
|
tests/unit/test-smp-parse.c | 10 ----------
|
||
|
|
1 file changed, 10 deletions(-)
|
||
|
|
|
||
|
|
diff --git a/tests/unit/test-smp-parse.c b/tests/unit/test-smp-parse.c
|
||
|
|
index 331719bbc4..72d83d1bbc 100644
|
||
|
|
--- a/tests/unit/test-smp-parse.c
|
||
|
|
+++ b/tests/unit/test-smp-parse.c
|
||
|
|
@@ -523,8 +523,6 @@ static void machine_base_class_init(ObjectClass *oc, void *data)
|
||
|
|
{
|
||
|
|
MachineClass *mc = MACHINE_CLASS(oc);
|
||
|
|
|
||
|
|
- mc->smp_props.prefer_sockets = true;
|
||
|
|
-
|
||
|
|
mc->name = g_strdup(SMP_MACHINE_NAME);
|
||
|
|
}
|
||
|
|
|
||
|
|
@@ -534,9 +532,6 @@ static void machine_generic_valid_class_init(ObjectClass *oc, void *data)
|
||
|
|
|
||
|
|
mc->min_cpus = MIN_CPUS;
|
||
|
|
mc->max_cpus = MAX_CPUS;
|
||
|
|
-
|
||
|
|
- mc->smp_props.dies_supported = false;
|
||
|
|
- mc->smp_props.clusters_supported = false;
|
||
|
|
}
|
||
|
|
|
||
|
|
static void machine_generic_invalid_class_init(ObjectClass *oc, void *data)
|
||
|
|
@@ -546,9 +541,6 @@ static void machine_generic_invalid_class_init(ObjectClass *oc, void *data)
|
||
|
|
/* Force invalid min CPUs and max CPUs */
|
||
|
|
mc->min_cpus = 2;
|
||
|
|
mc->max_cpus = 511;
|
||
|
|
-
|
||
|
|
- mc->smp_props.dies_supported = false;
|
||
|
|
- mc->smp_props.clusters_supported = false;
|
||
|
|
}
|
||
|
|
|
||
|
|
static void machine_with_dies_class_init(ObjectClass *oc, void *data)
|
||
|
|
@@ -559,7 +551,6 @@ static void machine_with_dies_class_init(ObjectClass *oc, void *data)
|
||
|
|
mc->max_cpus = MAX_CPUS;
|
||
|
|
|
||
|
|
mc->smp_props.dies_supported = true;
|
||
|
|
- mc->smp_props.clusters_supported = false;
|
||
|
|
}
|
||
|
|
|
||
|
|
static void machine_with_clusters_class_init(ObjectClass *oc, void *data)
|
||
|
|
@@ -570,7 +561,6 @@ static void machine_with_clusters_class_init(ObjectClass *oc, void *data)
|
||
|
|
mc->max_cpus = MAX_CPUS;
|
||
|
|
|
||
|
|
mc->smp_props.clusters_supported = true;
|
||
|
|
- mc->smp_props.dies_supported = false;
|
||
|
|
}
|
||
|
|
|
||
|
|
static void test_generic_valid(const void *opaque)
|
||
|
|
--
|
||
|
|
2.27.0
|
||
|
|
|