65 lines
2.6 KiB
Diff
65 lines
2.6 KiB
Diff
|
From ea14e0f1c97b6af8db9fa7b2d0df14ef03d9acb9 Mon Sep 17 00:00:00 2001
|
||
|
|
From: boringandboring <wangjinlei_yewu@cmss.chinamobile.com>
|
||
|
|
Date: Mon, 27 Nov 2023 14:04:58 +0800
|
||
|
|
Subject: [PATCH] tcg/loongarch64: Fix tcg_out_mov() Aborted
|
||
|
|
MIME-Version: 1.0
|
||
|
|
Content-Type: text/plain; charset=UTF-8
|
||
|
|
Content-Transfer-Encoding: 8bit
|
||
|
|
|
||
|
|
cherry picked from 85d57a37be1461d599747ab86dc0acc46732dbce
|
||
|
|
|
||
|
|
On LoongArch host, we got an Aborted from tcg_out_mov().
|
||
|
|
|
||
|
|
qemu-x86_64 configure with '--enable-debug'.
|
||
|
|
|
||
|
|
> (gdb) b /home1/gaosong/code/qemu/tcg/loongarch64/tcg-target.c.inc:312
|
||
|
|
> Breakpoint 1 at 0x2576f0: file /home1/gaosong/code/qemu/tcg/loongarch64/tcg-target.c.inc, line 312.
|
||
|
|
> (gdb) run hello
|
||
|
|
[...]
|
||
|
|
> Thread 1 "qemu-x86_64" hit Breakpoint 1, tcg_out_mov (s=0xaaaae91760 <tcg_init_ctx>, type=TCG_TYPE_V128, ret=TCG_REG_V2,
|
||
|
|
> arg=TCG_REG_V0) at /home1/gaosong/code/qemu/tcg/loongarch64/tcg-target.c.inc:312
|
||
|
|
> 312 g_assert_not_reached();
|
||
|
|
> (gdb) bt
|
||
|
|
> #0 tcg_out_mov (s=0xaaaae91760 <tcg_init_ctx>, type=TCG_TYPE_V128, ret=TCG_REG_V2, arg=TCG_REG_V0)
|
||
|
|
> at /home1/gaosong/code/qemu/tcg/loongarch64/tcg-target.c.inc:312
|
||
|
|
> #1 0x000000aaaad0fee0 in tcg_reg_alloc_mov (s=0xaaaae91760 <tcg_init_ctx>, op=0xaaaaf67c20) at ../tcg/tcg.c:4632
|
||
|
|
> #2 0x000000aaaad142f4 in tcg_gen_code (s=0xaaaae91760 <tcg_init_ctx>, tb=0xffe8030340 <code_gen_buffer+197328>,
|
||
|
|
> pc_start=4346094) at ../tcg/tcg.c:6135
|
||
|
|
[...]
|
||
|
|
> (gdb) c
|
||
|
|
> Continuing.
|
||
|
|
> **
|
||
|
|
> ERROR:/home1/gaosong/code/qemu/tcg/loongarch64/tcg-target.c.inc:312:tcg_out_mov: code should not be reached
|
||
|
|
> Bail out! ERROR:/home1/gaosong/code/qemu/tcg/loongarch64/tcg-target.c.inc:312:tcg_out_mov: code should not be reached
|
||
|
|
>
|
||
|
|
> Thread 1 "qemu-x86_64" received signal SIGABRT, Aborted.
|
||
|
|
> 0x000000fff7b1c390 in raise () from /lib64/libc.so.6
|
||
|
|
> (gdb) q
|
||
|
|
|
||
|
|
Fixes: 16288ded94 ("tcg/loongarch64: Lower basic tcg vec ops to LSX")
|
||
|
|
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
|
||
|
|
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
|
||
|
|
Signed-off-by: Song Gao <gaosong@loongson.cn>
|
||
|
|
Message-Id: <20231120065916.374045-1-gaosong@loongson.cn>
|
||
|
|
---
|
||
|
|
tcg/loongarch64/tcg-target.c.inc | 3 +++
|
||
|
|
1 file changed, 3 insertions(+)
|
||
|
|
|
||
|
|
diff --git a/tcg/loongarch64/tcg-target.c.inc b/tcg/loongarch64/tcg-target.c.inc
|
||
|
|
index 0b28b30002..ee7d4d728d 100644
|
||
|
|
--- a/tcg/loongarch64/tcg-target.c.inc
|
||
|
|
+++ b/tcg/loongarch64/tcg-target.c.inc
|
||
|
|
@@ -255,6 +255,9 @@ static bool tcg_out_mov(TCGContext *s, TCGType type, TCGReg ret, TCGReg arg)
|
||
|
|
*/
|
||
|
|
tcg_out_opc_or(s, ret, arg, TCG_REG_ZERO);
|
||
|
|
break;
|
||
|
|
+ case TCG_TYPE_V128:
|
||
|
|
+ tcg_out_opc_vori_b(s, ret, arg, 0);
|
||
|
|
+ break;
|
||
|
|
default:
|
||
|
|
g_assert_not_reached();
|
||
|
|
}
|
||
|
|
--
|
||
|
|
2.27.0
|
||
|
|
|