76 lines
2.7 KiB
Diff
76 lines
2.7 KiB
Diff
|
From b4bb154e6587b6d3fef819efcced803e309c4e05 Mon Sep 17 00:00:00 2001
|
||
|
|
From: yexiao <yexiao7@huawei.com>
|
||
|
|
Date: Thu, 21 Jan 2021 15:46:49 +0800
|
||
|
|
Subject: [PATCH] block-backend: Add timeout support for retry
|
||
|
|
|
||
|
|
Retry should only be triggered when timeout is not reached, so let's check
|
||
|
|
timeout before retry. Device should also reset retry_start_time after
|
||
|
|
successful retry.
|
||
|
|
|
||
|
|
Signed-off-by: Jiahui Cen <cenjiahui(a)huawei.com>
|
||
|
|
Signed-off-by: Ying Fang <fangying1(a)huawei.com>
|
||
|
|
Signed-off-by: Alex Chen <alex.chen@huawei.com>
|
||
|
|
---
|
||
|
|
block/block-backend.c | 25 ++++++++++++++++++++-
|
||
|
|
include/sysemu/block-backend-global-state.h | 1 +
|
||
|
|
2 files changed, 25 insertions(+), 1 deletion(-)
|
||
|
|
|
||
|
|
diff --git a/block/block-backend.c b/block/block-backend.c
|
||
|
|
index e62808fc03..919699bb70 100644
|
||
|
|
--- a/block/block-backend.c
|
||
|
|
+++ b/block/block-backend.c
|
||
|
|
@@ -2149,6 +2149,29 @@ void blk_drain_all(void)
|
||
|
|
bdrv_drain_all_end();
|
||
|
|
}
|
||
|
|
|
||
|
|
+static bool blk_error_retry_timeout(BlockBackend *blk)
|
||
|
|
+{
|
||
|
|
+ /* No timeout set, infinite retries. */
|
||
|
|
+ if (!blk->retry_timeout) {
|
||
|
|
+ return false;
|
||
|
|
+ }
|
||
|
|
+
|
||
|
|
+ /* The first time an error occurs. */
|
||
|
|
+ if (!blk->retry_start_time) {
|
||
|
|
+ blk->retry_start_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME);
|
||
|
|
+ return false;
|
||
|
|
+ }
|
||
|
|
+
|
||
|
|
+ return qemu_clock_get_ms(QEMU_CLOCK_REALTIME) > (blk->retry_start_time +
|
||
|
|
+ blk->retry_timeout);
|
||
|
|
+}
|
||
|
|
+
|
||
|
|
+void blk_error_retry_reset_timeout(BlockBackend *blk)
|
||
|
|
+{
|
||
|
|
+ if (blk->retry_timer && blk->retry_start_time)
|
||
|
|
+ blk->retry_start_time = 0;
|
||
|
|
+}
|
||
|
|
+
|
||
|
|
void blk_set_on_error(BlockBackend *blk, BlockdevOnError on_read_error,
|
||
|
|
BlockdevOnError on_write_error)
|
||
|
|
{
|
||
|
|
@@ -2180,7 +2203,7 @@ BlockErrorAction blk_get_error_action(BlockBackend *blk, bool is_read,
|
||
|
|
case BLOCKDEV_ON_ERROR_IGNORE:
|
||
|
|
return BLOCK_ERROR_ACTION_IGNORE;
|
||
|
|
case BLOCKDEV_ON_ERROR_RETRY:
|
||
|
|
- return (blk->retry_timer) ?
|
||
|
|
+ return (blk->retry_timer && !blk_error_retry_timeout(blk)) ?
|
||
|
|
BLOCK_ERROR_ACTION_RETRY : BLOCK_ERROR_ACTION_REPORT;
|
||
|
|
case BLOCKDEV_ON_ERROR_AUTO:
|
||
|
|
default:
|
||
|
|
diff --git a/include/sysemu/block-backend-global-state.h b/include/sysemu/block-backend-global-state.h
|
||
|
|
index 49c12b0fa9..7f59fd411d 100644
|
||
|
|
--- a/include/sysemu/block-backend-global-state.h
|
||
|
|
+++ b/include/sysemu/block-backend-global-state.h
|
||
|
|
@@ -84,6 +84,7 @@ int blk_commit_all(void);
|
||
|
|
bool blk_in_drain(BlockBackend *blk);
|
||
|
|
void blk_drain(BlockBackend *blk);
|
||
|
|
void blk_drain_all(void);
|
||
|
|
+void blk_error_retry_reset_timeout(BlockBackend *blk);
|
||
|
|
void blk_set_on_error(BlockBackend *blk, BlockdevOnError on_read_error,
|
||
|
|
BlockdevOnError on_write_error);
|
||
|
|
bool blk_supports_write_perm(BlockBackend *blk);
|
||
|
|
--
|
||
|
|
2.27.0
|
||
|
|
|