66 lines
2.5 KiB
Diff
66 lines
2.5 KiB
Diff
|
From 6c76354fdfbebca55e080fea5ae6bfc8a3db2d91 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Fabiano Rosas <farosas@suse.de>
|
||
|
|
Date: Mon, 17 Jun 2024 15:57:17 -0300
|
||
|
|
Subject: [PATCH] migration: Fix file migration with fdset
|
||
|
|
MIME-Version: 1.0
|
||
|
|
Content-Type: text/plain; charset=UTF-8
|
||
|
|
Content-Transfer-Encoding: 8bit
|
||
|
|
|
||
|
|
When the "file:" migration support was added we missed the special
|
||
|
|
case in the qemu_open_old implementation that allows for a particular
|
||
|
|
file name format to be used to refer to a set of file descriptors that
|
||
|
|
have been previously provided to QEMU via the add-fd QMP command.
|
||
|
|
|
||
|
|
When using this fdset feature, we should not truncate the migration
|
||
|
|
file because being given an fd means that the management layer is in
|
||
|
|
control of the file and will likely already have some data written to
|
||
|
|
it. This is further indicated by the presence of the 'offset'
|
||
|
|
argument, which indicates the start of the region where QEMU is
|
||
|
|
allowed to write.
|
||
|
|
|
||
|
|
Fix the issue by replacing the O_TRUNC flag on open by an ftruncate
|
||
|
|
call, which will take the offset into consideration.
|
||
|
|
|
||
|
|
Fixes: 385f510df5 ("migration: file URI offset")
|
||
|
|
Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
|
||
|
|
Reviewed-by: Prasad Pandit <pjp@fedoraproject.org>
|
||
|
|
Reviewed-by: Peter Xu <peterx@redhat.com>
|
||
|
|
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
|
||
|
|
Signed-off-by: Fabiano Rosas <farosas@suse.de>
|
||
|
|
(cherry picked from commit 6d3279655ac49b806265f08415165f471d33e032)
|
||
|
|
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
|
||
|
|
Signed-off-by: zhujun2 <zhujun2_yewu@cmss.chinamobile.com>
|
||
|
|
---
|
||
|
|
migration/file.c | 11 +++++++++--
|
||
|
|
1 file changed, 9 insertions(+), 2 deletions(-)
|
||
|
|
|
||
|
|
diff --git a/migration/file.c b/migration/file.c
|
||
|
|
index 5d4975f43e..fb3f743e54 100644
|
||
|
|
--- a/migration/file.c
|
||
|
|
+++ b/migration/file.c
|
||
|
|
@@ -46,12 +46,19 @@ void file_start_outgoing_migration(MigrationState *s,
|
||
|
|
|
||
|
|
trace_migration_file_outgoing(filename);
|
||
|
|
|
||
|
|
- fioc = qio_channel_file_new_path(filename, O_CREAT | O_WRONLY | O_TRUNC,
|
||
|
|
- 0600, errp);
|
||
|
|
+ fioc = qio_channel_file_new_path(filename, O_CREAT | O_WRONLY, 0600, errp);
|
||
|
|
if (!fioc) {
|
||
|
|
return;
|
||
|
|
}
|
||
|
|
|
||
|
|
+ if (ftruncate(fioc->fd, offset)) {
|
||
|
|
+ error_setg_errno(errp, errno,
|
||
|
|
+ "failed to truncate migration file to offset %" PRIx64,
|
||
|
|
+ offset);
|
||
|
|
+ object_unref(OBJECT(fioc));
|
||
|
|
+ return;
|
||
|
|
+ }
|
||
|
|
+
|
||
|
|
ioc = QIO_CHANNEL(fioc);
|
||
|
|
if (offset && qio_channel_io_seek(ioc, offset, SEEK_SET, errp) < 0) {
|
||
|
|
return;
|
||
|
|
--
|
||
|
|
2.41.0.windows.1
|
||
|
|
|