39 lines
1.4 KiB
Diff
39 lines
1.4 KiB
Diff
|
From 404c9b2cb537a42be18a1b1aaf32df662ed951e0 Mon Sep 17 00:00:00 2001
|
||
|
|
From: =?UTF-8?q?Eugenio=20P=C3=A9rez?= <eperezma@redhat.com>
|
||
|
|
Date: Tue, 17 Jan 2023 11:53:08 +0100
|
||
|
|
Subject: [PATCH] vdpa: fix VHOST_BACKEND_F_IOTLB_ASID flag check
|
||
|
|
MIME-Version: 1.0
|
||
|
|
Content-Type: text/plain; charset=UTF-8
|
||
|
|
Content-Transfer-Encoding: 8bit
|
||
|
|
|
||
|
|
VHOST_BACKEND_F_IOTLB_ASID is the feature bit, not the bitmask. Since
|
||
|
|
the device under test also provided VHOST_BACKEND_F_IOTLB_MSG_V2 and
|
||
|
|
VHOST_BACKEND_F_IOTLB_BATCH, this went unnoticed.
|
||
|
|
|
||
|
|
Fixes: c1a1008685 ("vdpa: always start CVQ in SVQ mode if possible")
|
||
|
|
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
|
||
|
|
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
|
||
|
|
Acked-by: Jason Wang <jasowang@redhat.com>
|
||
|
|
Signed-off-by: Jason Wang <jasowang@redhat.com>
|
||
|
|
Signed-off-by: fangyi <eric.fangyi@huawei.com>
|
||
|
|
---
|
||
|
|
net/vhost-vdpa.c | 2 +-
|
||
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||
|
|
|
||
|
|
diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
|
||
|
|
index cdc54a7b54..a1b931ae2c 100644
|
||
|
|
--- a/net/vhost-vdpa.c
|
||
|
|
+++ b/net/vhost-vdpa.c
|
||
|
|
@@ -391,7 +391,7 @@ static int vhost_vdpa_net_cvq_start(NetClientState *nc)
|
||
|
|
g_strerror(errno), errno);
|
||
|
|
return -1;
|
||
|
|
}
|
||
|
|
- if (!(backend_features & VHOST_BACKEND_F_IOTLB_ASID) ||
|
||
|
|
+ if (!(backend_features & BIT_ULL(VHOST_BACKEND_F_IOTLB_ASID)) ||
|
||
|
|
!vhost_vdpa_net_valid_svq_features(v->dev->features, NULL)) {
|
||
|
|
return 0;
|
||
|
|
}
|
||
|
|
--
|
||
|
|
2.27.0
|
||
|
|
|