40 lines
1.4 KiB
Diff
40 lines
1.4 KiB
Diff
|
From bdd1d8b5aea219c7ec1fb590430e3c8e99f43700 Mon Sep 17 00:00:00 2001
|
||
|
|
From: qihao_yewu <qihao_yewu@cmss.chinamobile.com>
|
||
|
|
Date: Mon, 18 Nov 2024 21:37:32 -0500
|
||
|
|
Subject: [PATCH] usb-hub: Fix handling port power control messages
|
||
|
|
MIME-Version: 1.0
|
||
|
|
Content-Type: text/plain; charset=UTF-8
|
||
|
|
Content-Transfer-Encoding: 8bit
|
||
|
|
|
||
|
|
cheery-pick from b2cc69997924b651c0c6f4037782e25f2e438715
|
||
|
|
|
||
|
|
The ClearPortFeature control message fails for PORT_POWER because there
|
||
|
|
is no break; at the end of the case statement, causing it to fall through
|
||
|
|
to the failure handler. Add the missing break; to solve the problem.
|
||
|
|
|
||
|
|
Fixes: 1cc403eb21 ("usb-hub: emulate per port power switching")
|
||
|
|
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
|
||
|
|
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
|
||
|
|
Message-ID: <20241112170152.217664-11-linux@roeck-us.net>
|
||
|
|
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
|
||
|
|
Signed-off-by: qihao_yewu <qihao_yewu@cmss.chinamobile.com>
|
||
|
|
---
|
||
|
|
hw/usb/dev-hub.c | 1 +
|
||
|
|
1 file changed, 1 insertion(+)
|
||
|
|
|
||
|
|
diff --git a/hw/usb/dev-hub.c b/hw/usb/dev-hub.c
|
||
|
|
index 5703e0e826..7b3cfa2c1b 100644
|
||
|
|
--- a/hw/usb/dev-hub.c
|
||
|
|
+++ b/hw/usb/dev-hub.c
|
||
|
|
@@ -479,6 +479,7 @@ static void usb_hub_handle_control(USBDevice *dev, USBPacket *p,
|
||
|
|
usb_hub_port_clear(port, PORT_STAT_SUSPEND);
|
||
|
|
port->wPortChange = 0;
|
||
|
|
}
|
||
|
|
+ break;
|
||
|
|
default:
|
||
|
|
goto fail;
|
||
|
|
}
|
||
|
|
--
|
||
|
|
2.41.0.windows.1
|
||
|
|
|