44 lines
1.5 KiB
Diff
44 lines
1.5 KiB
Diff
|
From 8c7e606ff2e59df7be719b13f28fe629414fcb30 Mon Sep 17 00:00:00 2001
|
||
|
|
From: =?UTF-8?q?Alex=20Benn=C3=A9e?= <alex.bennee@linaro.org>
|
||
|
|
Date: Tue, 5 Mar 2024 12:09:37 +0000
|
||
|
|
Subject: [PATCH] tests: bump QOS_PATH_MAX_ELEMENT_SIZE again
|
||
|
|
MIME-Version: 1.0
|
||
|
|
Content-Type: text/plain; charset=UTF-8
|
||
|
|
Content-Transfer-Encoding: 8bit
|
||
|
|
|
||
|
|
We "fixed" a bug with LTO builds with 100c459f194 (tests/qtest: bump
|
||
|
|
up QOS_PATH_MAX_ELEMENT_SIZE) but it seems it has triggered again.
|
||
|
|
|
||
|
|
The array is sized according to the maximum anticipated length of a
|
||
|
|
path on the graph. However, the worst case for a depth-first search is
|
||
|
|
to push all nodes on the graph. So it's not really LTO, it depends on
|
||
|
|
the ordering of the constructors.
|
||
|
|
|
||
|
|
Lets be more assertive raising QOS_PATH_MAX_ELEMENT_SIZE to make it go
|
||
|
|
away again.
|
||
|
|
|
||
|
|
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1186 (again)
|
||
|
|
Reviewed-by: Thomas Huth <thuth@redhat.com>
|
||
|
|
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
|
||
|
|
Message-Id: <20240305121005.3528075-2-alex.bennee@linaro.org>
|
||
|
|
---
|
||
|
|
tests/qtest/libqos/qgraph.h | 2 +-
|
||
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||
|
|
|
||
|
|
diff --git a/tests/qtest/libqos/qgraph.h b/tests/qtest/libqos/qgraph.h
|
||
|
|
index 287022a67c..1b5de02e7b 100644
|
||
|
|
--- a/tests/qtest/libqos/qgraph.h
|
||
|
|
+++ b/tests/qtest/libqos/qgraph.h
|
||
|
|
@@ -24,7 +24,7 @@
|
||
|
|
#include "libqos-malloc.h"
|
||
|
|
|
||
|
|
/* maximum path length */
|
||
|
|
-#define QOS_PATH_MAX_ELEMENT_SIZE 64
|
||
|
|
+#define QOS_PATH_MAX_ELEMENT_SIZE 128
|
||
|
|
|
||
|
|
typedef struct QOSGraphObject QOSGraphObject;
|
||
|
|
typedef struct QOSGraphNode QOSGraphNode;
|
||
|
|
--
|
||
|
|
2.41.0.windows.1
|
||
|
|
|