43 lines
1.5 KiB
Diff
43 lines
1.5 KiB
Diff
|
From 482808a35957c10d9eb4264492a8e11a2ba749c1 Mon Sep 17 00:00:00 2001
|
||
|
|
From: gubin <gubin_yewu@cmss.chinamobile.com>
|
||
|
|
Date: Fri, 22 Nov 2024 17:49:38 +0800
|
||
|
|
Subject: [PATCH] hw/audio/virtio-snd: Always use little endian audio format
|
||
|
|
MIME-Version: 1.0
|
||
|
|
Content-Type: text/plain; charset=UTF-8
|
||
|
|
Content-Transfer-Encoding: 8bit
|
||
|
|
|
||
|
|
cherry-pick from a276ec8e2632c9015d0f9b4e47194e4e91dfa8bb
|
||
|
|
|
||
|
|
The VIRTIO Sound Device conforms with the Virtio spec v1.2,
|
||
|
|
thus only use little endianness.
|
||
|
|
|
||
|
|
Remove the suspicious target_words_bigendian() noticed during
|
||
|
|
code review.
|
||
|
|
|
||
|
|
Cc: qemu-stable@nongnu.org
|
||
|
|
Fixes: eb9ad377bb ("virtio-sound: handle control messages and streams")
|
||
|
|
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
|
||
|
|
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
|
||
|
|
Message-Id: <20240422211830.25606-1-philmd@linaro.org>
|
||
|
|
Signed-off-by: gubin <gubin_yewu@cmss.chinamobile.com>
|
||
|
|
---
|
||
|
|
hw/audio/virtio-snd.c | 2 +-
|
||
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||
|
|
|
||
|
|
diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c
|
||
|
|
index 817fdcd910..9f7a69e408 100644
|
||
|
|
--- a/hw/audio/virtio-snd.c
|
||
|
|
+++ b/hw/audio/virtio-snd.c
|
||
|
|
@@ -377,7 +377,7 @@ static void virtio_snd_get_qemu_audsettings(audsettings *as,
|
||
|
|
as->nchannels = MIN(AUDIO_MAX_CHANNELS, params->channels);
|
||
|
|
as->fmt = virtio_snd_get_qemu_format(params->format);
|
||
|
|
as->freq = virtio_snd_get_qemu_freq(params->rate);
|
||
|
|
- as->endianness = target_words_bigendian() ? 1 : 0;
|
||
|
|
+ as->endianness = 0; /* Conforming to VIRTIO 1.0: always little endian. */
|
||
|
|
}
|
||
|
|
|
||
|
|
/*
|
||
|
|
--
|
||
|
|
2.41.0.windows.1
|
||
|
|
|