python-paramiko/0003-remove-pytest-relaxed-dep.patch

69 lines
2.3 KiB
Diff
Raw Normal View History

2022-06-23 10:51:16 +08:00
--- a/dev-requirements.txt
+++ b/dev-requirements.txt
@@ -2,7 +2,6 @@
invoke==1.6.0
invocations==2.6.0
pytest==4.4.2
-pytest-relaxed==1.1.5
# pytest-xdist for test dir watching and the inv guard task
pytest-xdist==1.28.0
mock==2.0.0
--- a/pytest.ini
+++ b/pytest.ini
@@ -1,7 +1,4 @@
[pytest]
-# We use pytest-relaxed just for its utils at the moment, so disable it at the
-# plugin level until we adapt test organization to really use it.
-addopts = -p no:relaxed
# Loop on failure
looponfailroots = tests paramiko
# Ignore some warnings we cannot easily handle.
2020-02-14 19:34:08 +08:00
--- a/tests/test_client.py
+++ b/tests/test_client.py
@@ -33,7 +33,7 @@ import warnings
import weakref
from tempfile import mkstemp
-from pytest_relaxed import raises
2022-06-23 10:51:16 +08:00
+import pytest
2021-01-30 11:44:42 +00:00
from mock import patch, Mock
2020-02-14 19:34:08 +08:00
import paramiko
2022-06-23 10:51:16 +08:00
@@ -733,11 +733,11 @@ class PasswordPassphraseTests(ClientTest
2020-02-14 19:34:08 +08:00
# TODO: more granular exception pending #387; should be signaling "no auth
# methods available" because no key and no password
- @raises(SSHException)
2022-06-23 10:51:16 +08:00
@requires_sha1_signing
2020-02-14 19:34:08 +08:00
def test_passphrase_kwarg_not_used_for_password_auth(self):
- # Using the "right" password in the "wrong" field shouldn't work.
2021-01-30 11:44:42 +00:00
- self._test_connection(passphrase="pygmalion")
2022-06-23 10:51:16 +08:00
+ with pytest.raises(SSHException):
2020-02-14 19:34:08 +08:00
+ # Using the "right" password in the "wrong" field shouldn't work.
2022-06-23 10:51:16 +08:00
+ self._test_connection(passphrase="pygmalion")
2020-02-14 19:34:08 +08:00
2022-06-23 10:51:16 +08:00
@requires_sha1_signing
2020-02-14 19:34:08 +08:00
def test_passphrase_kwarg_used_for_key_passphrase(self):
2022-06-23 10:51:16 +08:00
@@ -757,15 +757,15 @@ class PasswordPassphraseTests(ClientTest
2021-01-30 11:44:42 +00:00
password="television",
2020-02-14 19:34:08 +08:00
)
2021-01-30 11:44:42 +00:00
- @raises(AuthenticationException) # TODO: more granular
2022-06-23 10:51:16 +08:00
@requires_sha1_signing
2021-01-30 11:44:42 +00:00
def test_password_kwarg_not_used_for_passphrase_when_passphrase_kwarg_given( # noqa
self
):
2022-06-23 10:51:16 +08:00
# Sanity: if we're given both fields, the password field is NOT used as
# a passphrase.
2020-02-14 19:34:08 +08:00
- self._test_connection(
2021-01-30 11:44:42 +00:00
- key_filename=_support("test_rsa_password.key"),
- password="television",
- passphrase="wat? lol no",
2020-02-14 19:34:08 +08:00
- )
2022-06-23 10:51:16 +08:00
+ with pytest.raises(AuthenticationException):
2020-02-14 19:34:08 +08:00
+ self._test_connection(
2022-06-23 10:51:16 +08:00
+ key_filename=_support("test_rsa_password.key"),
+ password="television",
+ passphrase="wat? lol no",
2020-02-14 19:34:08 +08:00
+ )