106 lines
3.8 KiB
Diff
106 lines
3.8 KiB
Diff
|
|
From cb0e408e8b82fa8c198d9dd95e5818d8431e9fd5 Mon Sep 17 00:00:00 2001
|
||
|
|
From: chen-jan <chen_aka_jan@163.com>
|
||
|
|
Date: Tue, 11 Apr 2023 16:55:34 +0800
|
||
|
|
Subject: [PATCH] proftpd-1.3.8-fix-environment-sensitive-tests-failure
|
||
|
|
|
||
|
|
---
|
||
|
|
tests/api/netacl.c | 8 ++++++++
|
||
|
|
tests/api/netaddr.c | 6 ++++++
|
||
|
|
2 files changed, 14 insertions(+)
|
||
|
|
|
||
|
|
diff --git a/tests/api/netacl.c b/tests/api/netacl.c
|
||
|
|
index e4b0431..b91ecdb 100644
|
||
|
|
--- a/tests/api/netacl.c
|
||
|
|
+++ b/tests/api/netacl.c
|
||
|
|
@@ -775,8 +775,10 @@ START_TEST (netacl_match_test) {
|
||
|
|
res = pr_netacl_match(acl, addr);
|
||
|
|
if (getenv("CI") == NULL &&
|
||
|
|
getenv("TRAVIS") == NULL) {
|
||
|
|
+ if(strcmp(getenv("HOSTNAME"), "localhost") == 0 || strcmp(getenv("HOSTNAME"), "localhost.localdomain") == 0) {
|
||
|
|
ck_assert_msg(res == 1, "Failed to positively match ACL to addr: %s",
|
||
|
|
strerror(errno));
|
||
|
|
+ }
|
||
|
|
}
|
||
|
|
|
||
|
|
if (!have_localdomain) {
|
||
|
|
@@ -793,8 +795,10 @@ START_TEST (netacl_match_test) {
|
||
|
|
res = pr_netacl_match(acl, addr);
|
||
|
|
if (getenv("CI") == NULL &&
|
||
|
|
getenv("TRAVIS") == NULL) {
|
||
|
|
+ if(strcmp(getenv("HOSTNAME"), "localhost") == 0 || strcmp(getenv("HOSTNAME"), "localhost.localdomain") == 0) {
|
||
|
|
ck_assert_msg(res == -1, "Failed to negatively match ACL to addr: %s",
|
||
|
|
strerror(errno));
|
||
|
|
+ }
|
||
|
|
}
|
||
|
|
|
||
|
|
acl_str = "!www.google.com";
|
||
|
|
@@ -820,8 +824,10 @@ START_TEST (netacl_match_test) {
|
||
|
|
res = pr_netacl_match(acl, addr);
|
||
|
|
if (getenv("CI") == NULL &&
|
||
|
|
getenv("TRAVIS") == NULL) {
|
||
|
|
+ if(strcmp(getenv("HOSTNAME"), "localhost") == 0 || strcmp(getenv("HOSTNAME"), "localhost.localdomain") == 0) {
|
||
|
|
ck_assert_msg(res == 1, "Failed to positively match ACL to addr: %s",
|
||
|
|
strerror(errno));
|
||
|
|
+ }
|
||
|
|
}
|
||
|
|
|
||
|
|
if (!have_localdomain) {
|
||
|
|
@@ -838,8 +844,10 @@ START_TEST (netacl_match_test) {
|
||
|
|
res = pr_netacl_match(acl, addr);
|
||
|
|
if (getenv("CI") == NULL &&
|
||
|
|
getenv("TRAVIS") == NULL) {
|
||
|
|
+ if(strcmp(getenv("HOSTNAME"), "localhost") == 0 || strcmp(getenv("HOSTNAME"), "localhost.localdomain") == 0) {
|
||
|
|
ck_assert_msg(res == -1, "Failed to negatively match ACL to addr: %s",
|
||
|
|
strerror(errno));
|
||
|
|
+ }
|
||
|
|
}
|
||
|
|
|
||
|
|
acl_str = "!www.g*g.com";
|
||
|
|
diff --git a/tests/api/netaddr.c b/tests/api/netaddr.c
|
||
|
|
index e79b06c..b7dbeaf 100644
|
||
|
|
--- a/tests/api/netaddr.c
|
||
|
|
+++ b/tests/api/netaddr.c
|
||
|
|
@@ -424,8 +424,10 @@ START_TEST (netaddr_fnmatch_test) {
|
||
|
|
res = pr_netaddr_fnmatch(addr, "LOCAL*", flags);
|
||
|
|
if (getenv("CI") == NULL &&
|
||
|
|
getenv("TRAVIS") == NULL) {
|
||
|
|
+ if(strcmp(getenv("HOSTNAME"), "localhost") == 0 || strcmp(getenv("HOSTNAME"), "localhost.localdomain") == 0) {
|
||
|
|
/* This test is sensitive the environment. */
|
||
|
|
ck_assert_msg(res == TRUE, "Expected TRUE, got %d", res);
|
||
|
|
+ }
|
||
|
|
}
|
||
|
|
|
||
|
|
flags = PR_NETADDR_MATCH_IP;
|
||
|
|
@@ -887,10 +889,12 @@ START_TEST (netaddr_get_dnsstr_test) {
|
||
|
|
*/
|
||
|
|
if (getenv("CI") == NULL &&
|
||
|
|
getenv("TRAVIS") == NULL) {
|
||
|
|
+ if(strcmp(getenv("HOSTNAME"), "localhost") == 0 || strcmp(getenv("HOSTNAME"), "localhost.localdomain") == 0) {
|
||
|
|
/* This test is sensitive the environment. */
|
||
|
|
ck_assert_msg(strcmp(res, "localhost") == 0 ||
|
||
|
|
strcmp(res, "localhost.localdomain") == 0,
|
||
|
|
"Expected '%s', got '%s'", "localhost or localhost.localdomain", res);
|
||
|
|
+ }
|
||
|
|
}
|
||
|
|
}
|
||
|
|
END_TEST
|
||
|
|
@@ -1011,6 +1015,7 @@ START_TEST (netaddr_get_dnsstr_ipv6_test) {
|
||
|
|
*/
|
||
|
|
if (getenv("CI") == NULL &&
|
||
|
|
getenv("TRAVIS") == NULL) {
|
||
|
|
+ if(strcmp(getenv("HOSTNAME"), "localhost") == 0 || strcmp(getenv("HOSTNAME"), "localhost.localdomain") == 0) {
|
||
|
|
ck_assert_msg(strcmp(res, "localhost") == 0 ||
|
||
|
|
strcmp(res, "localhost.localdomain") == 0 ||
|
||
|
|
strcmp(res, "localhost6") == 0 ||
|
||
|
|
@@ -1019,6 +1024,7 @@ START_TEST (netaddr_get_dnsstr_ipv6_test) {
|
||
|
|
strcmp(res, "ip6-loopback") == 0 ||
|
||
|
|
strcmp(res, ip) == 0,
|
||
|
|
"Expected '%s', got '%s'", "localhost, localhost.localdomain et al", res);
|
||
|
|
+ }
|
||
|
|
}
|
||
|
|
}
|
||
|
|
END_TEST
|
||
|
|
--
|
||
|
|
2.39.1
|
||
|
|
|