27 lines
645 B
Diff
27 lines
645 B
Diff
From 9c977f94d59f55d86e6f0cfbc3cd9401861b75b0 Mon Sep 17 00:00:00 2001
|
|
From: jbj <jbj>
|
|
Date: Mon, 9 Aug 2010 17:31:45 +0000
|
|
Subject: [PATCH 051/157] - fix: obscure iconv mis-call error path could lead
|
|
to strdup(NULL) (coverity).
|
|
|
|
---
|
|
src/poptint.c | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
diff --git a/src/poptint.c b/src/poptint.c
|
|
index 5e09fa4..67f0051 100644
|
|
--- a/src/poptint.c
|
|
+++ b/src/poptint.c
|
|
@@ -145,7 +145,7 @@ assert(dstr); /* XXX can't happen */
|
|
}
|
|
(void) iconv_close(cd);
|
|
*pout = '\0';
|
|
- ostr = xstrdup(dstr);
|
|
+ ostr = xstrdup(dstr ? dstr : istr);
|
|
free(dstr);
|
|
} else
|
|
ostr = xstrdup(istr);
|
|
--
|
|
2.19.1
|
|
|