Compare commits

..

No commits in common. "4aa333eb7c02a4d7325c5381f5ffec85e74c5bbc" and "58a5f2841998d9f3cb9a53e13df6823a5cbbda4a" have entirely different histories.

5 changed files with 42 additions and 19 deletions

View File

@ -0,0 +1,37 @@
From ff8028c4d95425faa5b0705b8ed8c84b1112c7e4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com>
Date: Wed, 2 Aug 2017 17:29:13 +0200
Subject: [PATCH] Use exucatable name as a source of taintedness
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Test::Simple >= 1.302065 injects variables into the environment. These
are not tainted and caused a random t/07_taint.t test failures.
This patch fixes it by using executable name $0 instead.
https://github.com/pjf/ipc-system-simple/issues/21
Signed-off-by: Petr Písař <ppisar@redhat.com>
---
t/07_taint.t | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/07_taint.t b/t/07_taint.t
index 49cee12..be449cd 100644
--- a/t/07_taint.t
+++ b/t/07_taint.t
@@ -17,8 +17,8 @@ use_ok("IPC::System::Simple","run","capture");
chdir("t"); # Ignore return, since we may already be in t/
-my $taint = $ENV{(keys(%ENV))[0]} . "foo"; # ."foo" to avoid zero length
-ok(tainted($taint),"Sanity - ENV vars are tainted");
+my $taint = $0 . "foo"; # ."foo" to avoid zero length
+ok(tainted($taint),"Sanity - executable name is tainted");
my $evil_zero = 1 - (length($taint) / length($taint));
--
2.9.4

Binary file not shown.

Binary file not shown.

View File

@ -1,10 +1,12 @@
Name: perl-IPC-System-Simple
Version: 1.30
Release: 3
Version: 1.25
Release: 18
License: GPL+ or Artistic
Summary: Run commands simply, with detailed diagnostics
URL: http://search.cpan.org/dist/IPC-System-Simple
Source0: https://cpan.metacpan.org/authors/id/J/JK/JKEENAN/IPC-System-Simple-%{version}.tar.gz
Source0: http://search.cpan.org/CPAN/authors/id/P/PJ/PJF/IPC-System-Simple-%{version}.tar.gz
# Fix random test failures with Test-Simple 1.302065, proposed to upstream,
Patch0: IPC-System-Simple-1.25-Use-exucatable-name-as-a-source-of-taintedness.patch
BuildArch: noarch
# For Build
BuildRequires: coreutils findutils make perl-interpreter perl-generators perl(ExtUtils::MakeMaker) >= 6.30
@ -47,17 +49,5 @@ make test
%{_mandir}/man3/IPC::System::Simple.3*
%changelog
* Tue Oct 25 2022 dongyuzhen <dongyuzhen@h-partners.com> - 1.30-3
- Rebuild for next release
* Fri Sep 4 2020 shixuantong <shixuantong@huawei.com> - 1.30-2
- update Source0
* Fri Jul 24 2020 xinghe <xinghe1@huawei.com> - 1.30-1
- update version to 1.30
* Sat Jan 4 2020 openEuler Buildteam <buildteam@openeuler.org> - 1.25-19
- Delete redundant file
* Wed Sep 11 2019 openEuler Buildteam <buildteam@openeuler.org> - 1.25-18
- Package init

View File

@ -1,4 +0,0 @@
version_control: github
src_repo: pjf/ipc-system-simple
tag_prefix: ^v
seperator: .