!1 perl-System-Simple

Merge pull request !1 from syyhao/init
This commit is contained in:
openeuler-ci-bot 2020-01-09 09:59:26 +08:00 committed by Gitee
commit 903a8825ab
2 changed files with 4 additions and 40 deletions

View File

@ -1,37 +0,0 @@
From ff8028c4d95425faa5b0705b8ed8c84b1112c7e4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com>
Date: Wed, 2 Aug 2017 17:29:13 +0200
Subject: [PATCH] Use exucatable name as a source of taintedness
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Test::Simple >= 1.302065 injects variables into the environment. These
are not tainted and caused a random t/07_taint.t test failures.
This patch fixes it by using executable name $0 instead.
https://github.com/pjf/ipc-system-simple/issues/21
Signed-off-by: Petr Písař <ppisar@redhat.com>
---
t/07_taint.t | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/07_taint.t b/t/07_taint.t
index 49cee12..be449cd 100644
--- a/t/07_taint.t
+++ b/t/07_taint.t
@@ -17,8 +17,8 @@ use_ok("IPC::System::Simple","run","capture");
chdir("t"); # Ignore return, since we may already be in t/
-my $taint = $ENV{(keys(%ENV))[0]} . "foo"; # ."foo" to avoid zero length
-ok(tainted($taint),"Sanity - ENV vars are tainted");
+my $taint = $0 . "foo"; # ."foo" to avoid zero length
+ok(tainted($taint),"Sanity - executable name is tainted");
my $evil_zero = 1 - (length($taint) / length($taint));
--
2.9.4

View File

@ -1,12 +1,10 @@
Name: perl-IPC-System-Simple Name: perl-IPC-System-Simple
Version: 1.25 Version: 1.25
Release: 18 Release: 19
License: GPL+ or Artistic License: GPL+ or Artistic
Summary: Run commands simply, with detailed diagnostics Summary: Run commands simply, with detailed diagnostics
URL: http://search.cpan.org/dist/IPC-System-Simple URL: http://search.cpan.org/dist/IPC-System-Simple
Source0: http://search.cpan.org/CPAN/authors/id/P/PJ/PJF/IPC-System-Simple-%{version}.tar.gz Source0: http://search.cpan.org/CPAN/authors/id/P/PJ/PJF/IPC-System-Simple-%{version}.tar.gz
# Fix random test failures with Test-Simple 1.302065, proposed to upstream,
Patch0: IPC-System-Simple-1.25-Use-exucatable-name-as-a-source-of-taintedness.patch
BuildArch: noarch BuildArch: noarch
# For Build # For Build
BuildRequires: coreutils findutils make perl-interpreter perl-generators perl(ExtUtils::MakeMaker) >= 6.30 BuildRequires: coreutils findutils make perl-interpreter perl-generators perl(ExtUtils::MakeMaker) >= 6.30
@ -49,5 +47,8 @@ make test
%{_mandir}/man3/IPC::System::Simple.3* %{_mandir}/man3/IPC::System::Simple.3*
%changelog %changelog
* Sat Jan 4 2020 openEuler Buildteam <buildteam@openeuler.org> - 1.25-19
- Delete redundant file
* Wed Sep 11 2019 openEuler Buildteam <buildteam@openeuler.org> - 1.25-18 * Wed Sep 11 2019 openEuler Buildteam <buildteam@openeuler.org> - 1.25-18
- Package init - Package init