32 lines
1.5 KiB
Diff
32 lines
1.5 KiB
Diff
commit 55f9047c9da3edccf0bc7d80a09bcc2d92166da1
|
|
Author: Douglas Wilson <dougwilson@live.com>
|
|
Date: Sat May 5 19:18:29 2018 -0400
|
|
|
|
Use older semver style for old Node.js 0.10 npm versions (#182)
|
|
|
|
* Use older semver style for old Node.js 0.10 npm versions
|
|
* Fix test for changes Node.js 10 behavior
|
|
|
|
diff --git a/test/streams-test.js b/test/streams-test.js
|
|
index e1accff..3f7823f 100644
|
|
--- a/test/streams-test.js
|
|
+++ b/test/streams-test.js
|
|
@@ -214,13 +214,14 @@ describe("Streaming mode", function() {
|
|
input: [[0x3D], [0xD8, 0x3B], [0xDE]], // U+1F63B, 😻, SMILING CAT FACE WITH HEART-SHAPED EYES
|
|
outputType: false, // Don't concat
|
|
checkOutput: function(res) {
|
|
- if (semver.lt(process.version, "v6.2.1")) {
|
|
- assert.deepEqual(res, ["\uD83D\uDE3B"]); // We should have only 1 chunk.
|
|
- } else {
|
|
+ if (semver.satisfies(process.version, '>= 6.2.1 < 10.0.0')) {
|
|
// After a string_decoder rewrite in https://github.com/nodejs/node/pull/6777, which
|
|
// was merged in Node v6.2.1, we don't merge chunks anymore.
|
|
// Not really correct, but it seems we cannot do anything with it.
|
|
+ // Though it has been fixed again in Node v10.0.0
|
|
assert.deepEqual(res, ["\uD83D", "\uDE3B"]);
|
|
+ } else {
|
|
+ assert.deepEqual(res, ["\uD83D\uDE3B"]); // We should have only 1 chunk.
|
|
}
|
|
},
|
|
}));
|