fix CVE-2023-44487
This commit is contained in:
parent
2c11f8b82f
commit
458c1e49d5
76
backport-CVE-2023-44487.patch
Normal file
76
backport-CVE-2023-44487.patch
Normal file
@ -0,0 +1,76 @@
|
|||||||
|
From 6ceef192e7af1c507826ac38a2d43f08bf265fb9 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Maxim Dounin <mdounin@mdounin.ru>
|
||||||
|
Date: Tue, 10 Oct 2023 15:13:39 +0300
|
||||||
|
Subject: [PATCH] HTTP/2: per-iteration stream handling limit.
|
||||||
|
|
||||||
|
To ensure that attempts to flood servers with many streams are detected
|
||||||
|
early, a limit of no more than 2 * max_concurrent_streams new streams per one
|
||||||
|
event loop iteration was introduced. This limit is applied even if
|
||||||
|
max_concurrent_streams is not yet reached - for example, if corresponding
|
||||||
|
streams are handled synchronously or reset.
|
||||||
|
|
||||||
|
Further, refused streams are now limited to maximum of max_concurrent_streams
|
||||||
|
and 100, similarly to priority_limit initial value, providing some tolerance
|
||||||
|
to clients trying to open several streams at the connection start, yet
|
||||||
|
low tolerance to flooding attempts.
|
||||||
|
|
||||||
|
Conflict: context adapt
|
||||||
|
Reference: https://github.com/nginx/nginx/commit/6ceef192e7af1c507826ac38a2d43f08bf265fb9
|
||||||
|
---
|
||||||
|
src/http/v2/ngx_http_v2.c | 15 +++++++++++++++
|
||||||
|
src/http/v2/ngx_http_v2.h | 2 ++
|
||||||
|
2 files changed, 17 insertions(+)
|
||||||
|
|
||||||
|
diff --git a/src/http/v2/ngx_http_v2.c b/src/http/v2/ngx_http_v2.c
|
||||||
|
index 7c05ff1e78..410a8be24e 100644
|
||||||
|
--- a/src/http/v2/ngx_http_v2.c
|
||||||
|
+++ b/src/http/v2/ngx_http_v2.c
|
||||||
|
@@ -347,6 +347,7 @@ ngx_http_v2_read_handler(ngx_event_t *rev)
|
||||||
|
ngx_log_debug0(NGX_LOG_DEBUG_HTTP, c->log, 0, "http2 read handler");
|
||||||
|
|
||||||
|
h2c->blocked = 1;
|
||||||
|
+ h2c->new_streams = 0;
|
||||||
|
|
||||||
|
if (c->close) {
|
||||||
|
c->close = 0;
|
||||||
|
@@ -1284,6 +1285,14 @@ ngx_http_v2_state_headers(ngx_http_v2_connection_t *h2c, u_char *pos,
|
||||||
|
goto rst_stream;
|
||||||
|
}
|
||||||
|
|
||||||
|
+ if (h2c->new_streams++ >= 2 * h2scf->concurrent_streams) {
|
||||||
|
+ ngx_log_error(NGX_LOG_INFO, h2c->connection->log, 0,
|
||||||
|
+ "client sent too many streams at once");
|
||||||
|
+
|
||||||
|
+ status = NGX_HTTP_V2_REFUSED_STREAM;
|
||||||
|
+ goto rst_stream;
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
if (!h2c->settings_ack
|
||||||
|
&& !(h2c->state.flags & NGX_HTTP_V2_END_STREAM_FLAG)
|
||||||
|
&& h2scf->preread_size < NGX_HTTP_V2_DEFAULT_WINDOW)
|
||||||
|
@@ -1349,6 +1358,12 @@ ngx_http_v2_state_headers(ngx_http_v2_connection_t *h2c, u_char *pos,
|
||||||
|
|
||||||
|
rst_stream:
|
||||||
|
|
||||||
|
+ if (h2c->refused_streams++ > ngx_max(h2scf->concurrent_streams, 100)) {
|
||||||
|
+ ngx_log_error(NGX_LOG_INFO, h2c->connection->log, 0,
|
||||||
|
+ "client sent too many refused streams");
|
||||||
|
+ return ngx_http_v2_connection_error(h2c, NGX_HTTP_V2_NO_ERROR);
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
if (ngx_http_v2_send_rst_stream(h2c, h2c->state.sid, status) != NGX_OK) {
|
||||||
|
return ngx_http_v2_connection_error(h2c, NGX_HTTP_V2_INTERNAL_ERROR);
|
||||||
|
}
|
||||||
|
diff --git a/src/http/v2/ngx_http_v2.h b/src/http/v2/ngx_http_v2.h
|
||||||
|
index cb9014ccfb..6751b3026d 100644
|
||||||
|
--- a/src/http/v2/ngx_http_v2.h
|
||||||
|
+++ b/src/http/v2/ngx_http_v2.h
|
||||||
|
@@ -131,6 +131,8 @@ struct ngx_http_v2_connection_s {
|
||||||
|
ngx_uint_t processing;
|
||||||
|
ngx_uint_t frames;
|
||||||
|
ngx_uint_t idle;
|
||||||
|
+ ngx_uint_t new_streams;
|
||||||
|
+ ngx_uint_t refused_streams;
|
||||||
|
ngx_uint_t priority_limit;
|
||||||
|
|
||||||
|
ngx_uint_t pushing;
|
||||||
@ -17,7 +17,7 @@
|
|||||||
Name: nginx
|
Name: nginx
|
||||||
Epoch: 1
|
Epoch: 1
|
||||||
Version: 1.23.3
|
Version: 1.23.3
|
||||||
Release: 1
|
Release: 2
|
||||||
Summary: A HTTP server, reverse proxy and mail proxy server
|
Summary: A HTTP server, reverse proxy and mail proxy server
|
||||||
License: BSD
|
License: BSD
|
||||||
URL: http://nginx.org/
|
URL: http://nginx.org/
|
||||||
@ -39,6 +39,8 @@ Source210: UPGRADE-NOTES-1.6-to-1.10
|
|||||||
Patch0: nginx-auto-cc-gcc.patch
|
Patch0: nginx-auto-cc-gcc.patch
|
||||||
Patch1: nginx-1.12.1-logs-perm.patch
|
Patch1: nginx-1.12.1-logs-perm.patch
|
||||||
Patch2: nginx-fix-pidfile.patch
|
Patch2: nginx-fix-pidfile.patch
|
||||||
|
Patch3: backport-CVE-2023-44487.patch
|
||||||
|
|
||||||
BuildRequires: gcc openssl-devel pcre2-devel zlib-devel systemd gperftools-devel
|
BuildRequires: gcc openssl-devel pcre2-devel zlib-devel systemd gperftools-devel
|
||||||
Requires: nginx-filesystem = %{epoch}:%{version}-%{release} openssl
|
Requires: nginx-filesystem = %{epoch}:%{version}-%{release} openssl
|
||||||
Requires: nginx-all-modules = %{epoch}:%{version}-%{release}
|
Requires: nginx-all-modules = %{epoch}:%{version}-%{release}
|
||||||
@ -385,6 +387,9 @@ fi
|
|||||||
%{_mandir}/man8/nginx.8*
|
%{_mandir}/man8/nginx.8*
|
||||||
|
|
||||||
%changelog
|
%changelog
|
||||||
|
* Thu Oct 19 2023 yanglu <yanglu72@h-partners.com> - 1:1.23.3-2
|
||||||
|
- fix CVE-2023-44487
|
||||||
|
|
||||||
* Thu Mar 16 2023 gaihuiying <eaglegai@163.com> - 1:1.23.3-1
|
* Thu Mar 16 2023 gaihuiying <eaglegai@163.com> - 1:1.23.3-1
|
||||||
- update nginx to 1.23.3
|
- update nginx to 1.23.3
|
||||||
|
|
||||||
|
|||||||
Loading…
x
Reference in New Issue
Block a user