50 lines
1.4 KiB
Diff
50 lines
1.4 KiB
Diff
From 6bc6673fc88c8a3e3dd5504b2d24a6d6bc2f8427 Mon Sep 17 00:00:00 2001
|
|
From: Pablo Neira Ayuso <pablo@netfilter.org>
|
|
Date: Wed, 10 Jan 2024 18:18:50 +0100
|
|
Subject: [PATCH] evaluate: skip anonymous set optimization for concatenations
|
|
|
|
Concatenation is only supported with sets. Moreover, stripping of the
|
|
set leads to broken ruleset listing, therefore, skip this optimization
|
|
for the concatenations.
|
|
|
|
Fixes: fa17b17ea74a ("evaluate: revisit anonymous set with single element optimization")
|
|
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
|
|
---
|
|
src/evaluate.c | 20 +++++++++++---------
|
|
1 file changed, 11 insertions(+), 9 deletions(-)
|
|
|
|
diff --git a/src/evaluate.c b/src/evaluate.c
|
|
index b13e7c02..78732c6e 100644
|
|
--- a/src/evaluate.c
|
|
+++ b/src/evaluate.c
|
|
@@ -2580,15 +2580,17 @@ static int expr_evaluate_relational(struct eval_ctx *ctx, struct expr **expr)
|
|
return expr_binary_error(ctx->msgs, right, left,
|
|
"Cannot be used with right hand side constant value");
|
|
|
|
- switch (rel->op) {
|
|
- case OP_EQ:
|
|
- case OP_IMPLICIT:
|
|
- case OP_NEQ:
|
|
- if (right->etype == EXPR_SET && right->size == 1)
|
|
- optimize_singleton_set(rel, &right);
|
|
- break;
|
|
- default:
|
|
- break;
|
|
+ if (left->etype != EXPR_CONCAT) {
|
|
+ switch (rel->op) {
|
|
+ case OP_EQ:
|
|
+ case OP_IMPLICIT:
|
|
+ case OP_NEQ:
|
|
+ if (right->etype == EXPR_SET && right->size == 1)
|
|
+ optimize_singleton_set(rel, &right);
|
|
+ break;
|
|
+ default:
|
|
+ break;
|
|
+ }
|
|
}
|
|
|
|
switch (rel->op) {
|
|
--
|
|
2.33.0
|
|
|