44 lines
2.0 KiB
Diff
44 lines
2.0 KiB
Diff
From b626c86abaf294fcf1ec788f722071dc90da68c4 Mon Sep 17 00:00:00 2001
|
|
From: Florian Westphal <fw@strlen.de>
|
|
Date: Fri, 15 Dec 2023 10:19:02 +0100
|
|
Subject: [PATCH] evaluate: fix stack overflow with huge priority string
|
|
|
|
Alternative would be to refactor this and move this into the parsers
|
|
(bison, json) instead of this hidden re-parsing.
|
|
|
|
Fixes: 627c451b2351 ("src: allow variables in the chain priority specification")
|
|
Signed-off-by: Florian Westphal <fw@strlen.de>
|
|
---
|
|
src/evaluate.c | 2 +-
|
|
tests/shell/testcases/bogons/nft-f/huge_chain_prio | 5 +++++
|
|
2 files changed, 6 insertions(+), 1 deletion(-)
|
|
create mode 100644 tests/shell/testcases/bogons/nft-f/huge_chain_prio
|
|
|
|
diff --git a/src/evaluate.c b/src/evaluate.c
|
|
index 87cd68d3..5ddbde42 100644
|
|
--- a/src/evaluate.c
|
|
+++ b/src/evaluate.c
|
|
@@ -4897,7 +4897,7 @@ static bool evaluate_priority(struct eval_ctx *ctx, struct prio_spec *prio,
|
|
NFT_NAME_MAXLEN);
|
|
loc = prio->expr->location;
|
|
|
|
- if (sscanf(prio_str, "%s %c %d", prio_fst, &op, &prio_snd) < 3) {
|
|
+ if (sscanf(prio_str, "%255s %c %d", prio_fst, &op, &prio_snd) < 3) {
|
|
priority = std_prio_lookup(prio_str, family, hook);
|
|
if (priority == NF_IP_PRI_LAST)
|
|
return false;
|
|
diff --git a/tests/shell/testcases/bogons/nft-f/huge_chain_prio b/tests/shell/testcases/bogons/nft-f/huge_chain_prio
|
|
new file mode 100644
|
|
index 00000000..41f8061a
|
|
--- /dev/null
|
|
+++ b/tests/shell/testcases/bogons/nft-f/huge_chain_prio
|
|
@@ -0,0 +1,5 @@
|
|
+table t {
|
|
+ chain c {
|
|
+ type filter hook input priority srcnDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDD#DDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDD; policy accept;
|
|
+ }
|
|
+}
|
|
--
|
|
2.33.0
|
|
|