82 lines
2.3 KiB
Diff
82 lines
2.3 KiB
Diff
|
From 27039be7cfd551646425b0ebc43a87e86484c370 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Benjamin Marzinski <bmarzins@redhat.com>
|
||
|
|
Date: Fri, 23 Aug 2019 12:48:50 -0500
|
||
|
|
Subject: [PATCH 8/8] libmultipath: fix double free in pgpolicyfn error paths
|
||
|
|
|
||
|
|
In the pgpolicy functions, if an error is encountered after
|
||
|
|
alloc_pathgroup() is called, but before the path group is added to a
|
||
|
|
multipath device with add_pathgroup(), the pathgroup needs to be cleaned
|
||
|
|
up by calling free_pathgroup(). However, after the pathgroup has been
|
||
|
|
added to the multipath device, calling free_pgvec() will clean it up. In
|
||
|
|
this case, if free_pathgroup() is called first, the recently added
|
||
|
|
pathgroup will be freed twice.
|
||
|
|
|
||
|
|
Reviewed-by: Martin Wilck <mwilck@suse.com>
|
||
|
|
Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
|
||
|
|
---
|
||
|
|
libmultipath/pgpolicies.c | 12 ++++++------
|
||
|
|
1 file changed, 6 insertions(+), 6 deletions(-)
|
||
|
|
|
||
|
|
diff --git a/libmultipath/pgpolicies.c b/libmultipath/pgpolicies.c
|
||
|
|
index 660768a..9acf46a 100644
|
||
|
|
--- a/libmultipath/pgpolicies.c
|
||
|
|
+++ b/libmultipath/pgpolicies.c
|
||
|
|
@@ -125,7 +125,7 @@ int group_by_node_name(struct multipath * mp)
|
||
|
|
|
||
|
|
/* feed the first path */
|
||
|
|
if (store_path(pgp->paths, pp))
|
||
|
|
- goto out2;
|
||
|
|
+ goto out1;
|
||
|
|
|
||
|
|
bitmap[i] = 1;
|
||
|
|
|
||
|
|
@@ -139,7 +139,7 @@ int group_by_node_name(struct multipath * mp)
|
||
|
|
if (!strncmp(pp->tgt_node_name, pp2->tgt_node_name,
|
||
|
|
NODE_NAME_SIZE)) {
|
||
|
|
if (store_path(pgp->paths, pp2))
|
||
|
|
- goto out2;
|
||
|
|
+ goto out1;
|
||
|
|
|
||
|
|
bitmap[j] = 1;
|
||
|
|
}
|
||
|
|
@@ -201,7 +201,7 @@ int group_by_serial(struct multipath * mp)
|
||
|
|
|
||
|
|
/* feed the first path */
|
||
|
|
if (store_path(pgp->paths, pp))
|
||
|
|
- goto out2;
|
||
|
|
+ goto out1;
|
||
|
|
|
||
|
|
bitmap[i] = 1;
|
||
|
|
|
||
|
|
@@ -214,7 +214,7 @@ int group_by_serial(struct multipath * mp)
|
||
|
|
|
||
|
|
if (0 == strcmp(pp->serial, pp2->serial)) {
|
||
|
|
if (store_path(pgp->paths, pp2))
|
||
|
|
- goto out2;
|
||
|
|
+ goto out1;
|
||
|
|
|
||
|
|
bitmap[j] = 1;
|
||
|
|
}
|
||
|
|
@@ -258,7 +258,7 @@ int one_path_per_group(struct multipath *mp)
|
||
|
|
goto out1;
|
||
|
|
|
||
|
|
if (store_path(pgp->paths, pp))
|
||
|
|
- goto out1;
|
||
|
|
+ goto out;
|
||
|
|
}
|
||
|
|
sort_pathgroups(mp);
|
||
|
|
free_pathvec(mp->paths, KEEP_PATHS);
|
||
|
|
@@ -379,7 +379,7 @@ int group_by_prio(struct multipath *mp)
|
||
|
|
vector_foreach_slot(pathvec, pp, i) {
|
||
|
|
if (pp->priority == prio) {
|
||
|
|
if (store_path(pgp->paths, pp))
|
||
|
|
- goto out2;
|
||
|
|
+ goto out1;
|
||
|
|
|
||
|
|
vector_del_slot(pathvec, i);
|
||
|
|
i--;
|
||
|
|
--
|
||
|
|
1.8.3.1
|
||
|
|
|
||
|
|
|